Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
erp5 erp5
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • erp5erp5
  • Merge requests
  • !734

Closed
Created Aug 31, 2018 by Ayush Tiwari@tiwariayushContributor3 of 3 tasks completed3/3 tasks
  • Report abuse
Report abuse

History Diff: Use of property as well as attributes to display diff

  • Overview 1
  • Commits 10
  • Changes 27

We use Report Section to display diff for properties as well as attribute dict. This will ensure that we have old_value, new_value and current_value for properties which are of type int/string/float and at the same time being able to use DiffTool to display diff for large text contents and provide link to the current_value.

Also, we simplify the way the current diff is being displayed in History Tab and let DiffTool calculate diff and then play with UI to display it as required.

Other extra changes include:

  • Remove redundant diff(ex: useless data, base_data and text_content redundancy)
  • Provide link for large content instead of displaying the data which is almost impossible to understand on the view.
  • Use DiffTool to handle the binary problem and display error, hence generalizing the case where diff is not calculated properly.

View of History in New UI:

Screenshot_2018-09-04_at_3.04.26_PM

View of History in Old UI:

Screenshot_2018-09-04_at_4.59.39_PM

Problems remaining:

  • report_view as page template doesn't support rendering of gadget.
  • Current Value Link is not working for new UI as there is no way to show the value through URL as we do in XHTML UI (ex: document_relative_url/getTextContent)
  • Remove showing redundant properties as data and text_content
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: history_diff
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7