nexedi / erp5

@Tyagov @jerome it seems you have work on this script from git history, can you pls check?

@xiaowu.zhang , if I can imagine correctly this will introspect all object_view definitions and got "form_id" from there.

Most likely it should be OK as long as object_view definitions keep expected standard (i.e. what you change and hard -code).

I would try to use grep and find inside git if this is the case and if this is it no objects to merge in on my side.

Yes, this introspect portal type definition to make a report with one report section for each view of a document, and this part parses the URL to get the form id.

It did not work when the action url had a "?=/"

this fix seems correct to me.

we cannot use urlparse module in restricted python ? this would be a more "beautiful" way than parsing url like this.

If I understand correctly an action like this

string:${object_url}/Base_viewSomething?something=${here/getRelativeUrl}

triggers the bug ( I did not find any in nexedi/erp5.git , but it really seems a bug in this script, no reason not to support such actions )

If I understand correctly an action like this

string:${object_url}/Base_viewSomething?something=${here/getRelativeUrl}

yes, in some other project we have.

i find in nexedi/erp5.git, related document view

for this view, the url is something like:

https://erp5xxxx/document_module/7873/Document_viewRelated?cancel_url=https%3A//erp5xxxx/document_module/7873/File_view&object_uid=20154xxxxx&form_id=File_view&object_path=/nexedi/document_module/7873

which cause problem when make a report

we cannot use urlparse module in restricted python ? this would be a more "beautiful" way than parsing url like this.

no, i got error when access ParseResult's attribute

Site Error
An error was encountered while publishing this resource.

Error Type: Unauthorized
Error Value: You are not allowed to access 'path' in this context

Ah thanks for trying. I guess we can leave the urlparse refactoring for later.

I see urlparse was allow_module'd in de2001ff but ParseResult ( there's also SplitResult or DefragResult) were not allowed. I doubt there's a security reason behind.

Most likely it should be OK as long as object_view definitions keep expected standard

i check all object_view in erp5, it's all in string:${object_url}/form_viewSomething format

so i think it's ok to merge

anyway, i'll wait for my test result

@xiaowu.zhang , thanks. Please merge if test passes.

mentioned in commit 96347a03

merged

mentioned in merge request !839 (merged)