project: make Project Cell use OrderCell class
erp5_project does not depend on erp5_budget, so instanciating project cell fail unless erp5_budget is installed.
Project Cell are not used by default, so it's still a bit unclear, but with erp5_budget we can directly define budgets by project / project lines in a more flexible (but also more complex).
Project Line uses OrderLine, so it's consistent to use OrderCell for Project Cell.
-
changed title from project: make Project Cell use Predicate class to project: make Project Cell use OrderCell class
Toggle commit list -
@romain @rporchetto do you see a problem with this ? In your work on project you don't plan to allow defining budgets or anything using
Project Cell
?I think that the history of this portal type is that it has been created so that maybe one day we can maybe define budget for project, but since that erp5_budget evolve to a module allowing to define budget for anything (including projects).
I'm just interested of making it possible to create project cell when erp5_budget is not installed.
-
For reference budget cell class is https://lab.nexedi.com/nexedi/erp5/blob/0d702108e25107e4ba71e713ee723ee10c4f00fa/bt5/erp5_budget/DocumentTemplateItem/portal_components/document.erp5.BudgetCell.py , I don't think we use any of these methods on a Project Cell.
-
I'll ask him next time I have a chance to talk to him, this is not at all urgent.
Also, I would be very surprise that this change has any consequence with what's currently working. I was asking because you are working on some new things around project, but if you are not planning to use project cell in this work, we can probably apply this change, it would still be possible to define budgets for project from budget module the same way that we do today.
-
Please register or sign in to post a comment