Adding an exmple for using ipv6
Ready to be merged automatically
Ask someone with write access to this repository to merge this request.
@kirr started a discussion on an outdated diffexample/ipv6.cfg 0 → 100644
76 @type stdout 77 @id stdout_output 78 </match> 79 80 81 ## match fluent's internal events 82 #<match fluent.**> 83 # @type null 84 #</match> 85 86 ## match not matched logs and write to file 87 #<match **> 88 # @type file 89 # path /var/log/fluent/else 90 # compress gz 91 #</match>
@valentin, thanks for the patch. I have a suggestion: your patch makes almost verbatim copy of
example/to_wendelin.conf, and without looking into details it is not even clear what is IPv6 specific in your example.
I looked into detail and saw this:
kirr@deco:~/src/wendelin/fluent-plugin-wendelin$ git show -C -C nxd/mr/3
commit 7ab0483312608b6b24d509e562d56a1b59ab94ef (nxd/mr/3) Author: valentin <email@example.com> Date: Tue Apr 24 12:14:15 2018 +0200 Adding an exmple for using ipv6 diff --git a/example/to_wendelin.conf b/example/ipv6.cfg similarity index 99% copy from example/to_wendelin.conf copy to example/ipv6.cfg index ff267ff..9b7cee8 100644 --- a/example/to_wendelin.conf +++ b/example/ipv6.cfg @@ -6,6 +6,7 @@ <source> @type forward @id forward_input + bind :: </source>
so it turns out you simply add
This way I suggest you to rework the patch to add options you need to
example/to_wendelin.confdirectly, probably with comments there saying something that these options are needed for such and such use cases.
By the way it would be good to have the description in the commit message itself too, because even after seeing the denoised patch and your commit description I cannot say it is clear to me why and in which context the change is needed.
Let me know if something needs to be clarified.
Added 1 commit:
Toggle commit list
- 58caf223 - Adding ipv6 compatibility