Merge branch '222311-do-not-suggest-pipeline-on-merged' into 'master'

Resolved MRs should not show suggest pipeline popup

See merge request gitlab-org/gitlab!34639

app/serializers/merge_request_widget_entity.rb

@@ -95,6 +95,8 @@ class MergeRequestWidgetEntity < Grape::Entity
   end
 
   def can_add_ci_config_path?(merge_request)
+    merge_request.open? &&
+      merge_request.source_branch_exists? &&
       merge_request.source_project&.uses_default_ci_config? &&
       !merge_request.source_project.has_ci? &&
       merge_request.commits_count.positive? &&

spec/serializers/merge_request_widget_entity_spec.rb

@@ -155,6 +155,36 @@ describe MergeRequestWidgetEntity do
             expect(subject[:merge_request_add_ci_config_path]).to be_nil
           end
         end
+
+        context 'when merge request is merged' do
+          before do
+            resource.mark_as_merged!
+          end
+
+          it 'returns a blank ci config path' do
+            expect(subject[:merge_request_add_ci_config_path]).to be_nil
+          end
+        end
+
+        context 'when merge request is closed' do
+          before do
+            resource.close!
+          end
+
+          it 'returns a blank ci config path' do
+            expect(subject[:merge_request_add_ci_config_path]).to be_nil
+          end
+        end
+
+        context 'when source branch does not exist' do
+          before do
+            resource.source_project.repository.rm_branch(user, resource.source_branch)
+          end
+
+          it 'returns a blank ci config path' do
+            expect(subject[:merge_request_add_ci_config_path]).to be_nil
+          end
+        end
       end
 
       context 'when user does not have permissions' do