Fix eslint violations and update locale strings

app/assets/javascripts/serverless/survey_banner.js

@@ -22,7 +22,6 @@ export default function initServerlessSurveyBanner() {
       SURVEY_URL_BASE,
     );
 
-    // eslint-disable-next-line no-new
     bannerInstance = new Vue({
       el,
       render(createElement) {

app/assets/javascripts/serverless/survey_banner.vue

@@ -2,23 +2,27 @@
 import Cookies from 'js-cookie';
 import { parseBoolean } from '~/lib/utils/common_utils';
 import { GlBanner } from '@gitlab/ui';
-import { s__ } from '../locale';
 
 export default {
   components: {
     GlBanner,
   },
-  data() {
-    return {
-      visible: true,
-    };
-  },
   props: {
     surveyUrl: {
       type: String,
       required: true,
     },
   },
+  data() {
+    return {
+      visible: true,
+    };
+  },
+  created() {
+    if (parseBoolean(Cookies.get('hide_serverless_survey'))) {
+      this.visible = false;
+    }
+  },
   methods: {
     handleClose() {
       Cookies.set('hide_serverless_survey', 'true', {
@@ -28,11 +32,6 @@ export default {
       this.visible = false;
     },
   },
-  beforeMount() {
-    if (parseBoolean(Cookies.get('hide_serverless_survey'))) {
-      this.visible = false;
-    }
-  },
 };
 </script>
 

locale/gitlab.pot

@@ -10446,6 +10446,9 @@ msgstr ""
 msgid "Help page text and support page url."
 msgstr ""
 
+msgid "Help shape the future of Serverless at GitLab"
+msgstr ""
+
 msgid "Helps prevent bots from brute-force attacks."
 msgstr ""
 
@@ -17954,6 +17957,9 @@ msgstr ""
 msgid "Serverless|No functions available"
 msgstr ""
 
+msgid "Serverless|Sign up for First Look"
+msgstr ""
+
 msgid "Serverless|The deploy job has not finished."
 msgstr ""
 
@@ -17963,6 +17969,9 @@ msgstr ""
 msgid "Serverless|There is currently no function data available from Knative. This could be for a variety of reasons including:"
 msgstr ""
 
+msgid "Serverless|We are continually striving to improve our Serverless functionality. As a Knative user, we would love to hear how we can make this experience better for you. Sign up for GitLab First Look today and we will be in touch shortly."
+msgstr ""
+
 msgid "Serverless|Your %{startTag}.gitlab-ci.yml%{endTag} file is not properly configured."
 msgstr ""