Replace rails_helper.rb with spec_helper.rb

rails_helper.rb's only logic was to require
spec_helper.rb.

.rubocop.yml

@@ -264,8 +264,6 @@ RSpec/EnvAssignment:
   Exclude:
     - 'spec/**/fast_spec_helper.rb'
     - 'ee/spec/**/fast_spec_helper.rb'
-    - 'spec/**/rails_helper.rb'
-    - 'ee/spec/**/rails_helper.rb'
     - 'spec/**/spec_helper.rb'
     - 'ee/spec/**/spec_helper.rb'
 RSpec/BeSuccessMatcher:

bin/rspec-stackprof

@@ -3,7 +3,7 @@
 require 'bundler/setup'
 require 'stackprof'
 $:.unshift 'spec'
-require 'rails_helper'
+require 'spec_helper'
 
 filename = ARGV[0].split('/').last
 interval = ENV.fetch('INTERVAL', 1000).to_i

doc/development/gotchas.md

@@ -18,7 +18,7 @@ end
 Consider the following API spec:
 
 ```ruby
-require 'rails_helper'
+require 'spec_helper'
 
 describe API::Labels do
   it 'creates a first label' do
@@ -69,7 +69,7 @@ is ok, but `create(:label, title: 'label1')` is not.
 Following is the fixed API spec:
 
 ```ruby
-require 'rails_helper'
+require 'spec_helper'
 
 describe API::Labels do
   it 'creates a first label' do

ee/spec/controllers/ee/sent_notifications_controller_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe SentNotificationsController do
   let(:user) { create(:user) }

ee/spec/controllers/projects/approver_groups_controller_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Projects::ApproverGroupsController do
   describe '#destroy' do

ee/spec/controllers/projects/approvers_controller_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Projects::ApproversController do
   describe '#destroy' do

ee/spec/controllers/projects/path_locks_controller_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Projects::PathLocksController do
   let(:project) { create(:project, :repository, :public) }

ee/spec/features/boards/add_issues_modal_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards add issue modal', :js do
   let(:project) { create(:project, :public) }

ee/spec/features/boards/focus_mode_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards focus mode', :js do
   let(:project) { create(:project, :public) }

ee/spec/features/boards/group_boards/multiple_boards_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Multiple Issue Boards', :js do
   set(:user) { create(:user) }

ee/spec/features/boards/scoped_issue_board_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Scoped issue boards', :js do
   include FilteredSearchHelpers

ee/spec/features/boards/sidebar_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards', :js do
   include BoardHelpers

ee/spec/features/epics/gfm_autocomplete_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'GFM autocomplete', :js do
   let(:user) { create(:user, name: '💃speciąl someone💃', username: 'someone.special') }

ee/spec/features/epics/todo_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Manually create a todo item from epic', :js do
   let(:group) { create(:group) }

ee/spec/features/groups/hooks/user_tests_hooks_spec.rb

-require "rails_helper"
+require 'spec_helper'
 
 describe "User tests hooks", :js do
   include StubRequests

ee/spec/features/issuables/related_issues_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Related issues', :js do
   let(:user) { create(:user) }

ee/spec/features/issues/filtered_search/dropdown_weight_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Dropdown weight', :js do
   include FilteredSearchHelpers

ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Filter issues weight', :js do
   include FilteredSearchHelpers

ee/spec/features/issues/form_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'New/edit issue', :js do
   include GitlabRoutingHelper

ee/spec/features/issues/issue_sidebar_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Sidebar' do
   include MobileHelpers

ee/spec/features/merge_request/batch_comments_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > Batch comments', :js do
   include MergeRequestDiffHelpers

ee/spec/features/merge_request/user_approves_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 # TODO: https://gitlab.com/gitlab-org/gitlab-ee/issues/9430
 xdescribe 'Merge request > User approves', :js do

ee/spec/features/merge_request/user_approves_with_password_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User approves with password', :js do
   let(:user) { create(:user) }

ee/spec/features/merge_request/user_reviews_image_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > image review', :js do
   include MergeRequestDiffHelpers

ee/spec/features/merge_request/user_sees_approval_widget_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User sees approval widget', :js do
   let(:project) { create(:project, :public, :repository) }

ee/spec/features/merge_request/user_sees_deployment_widget_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User sees deployment widget', :js do
   describe 'when merge request has associated environments' do

ee/spec/features/merge_request/user_sees_merge_widget_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User sees merge widget', :js do
   include ProjectForksHelper

ee/spec/features/merge_request/user_selects_branches_for_new_mr_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User selects branches for new MR', :js do
   let(:project) { create(:project, :public, :repository) }

ee/spec/features/merge_request/user_sets_approval_rules_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User sets approval rules', :js do
   include ProjectForksHelper

ee/spec/features/merge_request/user_sets_approvers_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User sets approvers', :js do
   include ProjectForksHelper

ee/spec/features/merge_request/user_uses_slash_commands_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge request > User uses quick actions', :js do
   include Spec::Support::Helpers::Features::NotesHelpers

ee/spec/features/merge_requests/user_filters_by_approvers_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Merge Requests > User filters by approvers', :js do
   include FilteredSearchHelpers

ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Two merge requests on a merge train' do
   include RepoHelpers

ee/spec/features/merge_trains/user_adds_merge_request_to_merge_train_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'User adds a merge request to a merge train', :js do
   let(:project) { create(:project, :repository) }

ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'User adds to merge train when pipeline succeeds', :js do
   let(:project) { create(:project, :repository) }

ee/spec/features/profiles/account_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Profile > Account' do
   let(:user) { create(:user) }

ee/spec/features/projects/geo_clone_instructions_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Geo clone instructions', :geo, :js do
   include Devise::Test::IntegrationHelpers

ee/spec/features/projects/kerberos_clone_instructions_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Kerberos clone instructions', :js do
   include MobileHelpers

ee/spec/features/projects/settings/packages_settings_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Projects > Settings > Packages', :js do
   let(:project) { create(:project) }

ee/spec/features/projects/show/developer_views_empty_project_instructions_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Projects > Show > Developer views empty project instructions' do
   let(:project) { create(:project, :empty_repo) }

ee/spec/features/read_only_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Geo read-only message', :geo do
   include ::EE::GeoHelpers

ee/spec/lib/ee/gitlab/prometheus/metric_group_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Gitlab::Prometheus::MetricGroup do
   describe '.for_project' do

ee/spec/lib/gitlab/favicon_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Gitlab::Favicon, :request_store do
   describe '.main' do

ee/spec/lib/gitlab/sidekiq_config_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe Gitlab::SidekiqConfig do
   describe '.workers' do

ee/spec/models/audit_event_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe AuditEvent, type: :model do
   describe 'relationships' do

ee/spec/models/concerns/ee/deployment_platform_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe EE::DeploymentPlatform do
   describe '#deployment_platform' do

ee/spec/models/concerns/ee/noteable_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe EE::Noteable do
   subject(:klazz) { Class.new { include Noteable } }

ee/spec/models/dependency_proxy/blob_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe DependencyProxy::Blob, type: :model do
   describe 'relationships' do

ee/spec/models/dependency_proxy/group_setting_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe DependencyProxy::GroupSetting, type: :model do
   describe 'relationships' do

ee/spec/models/dependency_proxy/registry_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe DependencyProxy::Registry, type: :model do
   let(:tag)      { '2.3.5-alpine' }

ee/spec/models/design_management/design_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe DesignManagement::Design do
   include DesignManagementTestHelpers

ee/spec/models/design_management/design_version_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 describe DesignManagement::DesignVersion do
   describe 'relations' do

ee/spec/models/design_management/repository_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe DesignManagement::Repository do
   let(:project) { create(:project) }

ee/spec/models/design_management/version_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 describe DesignManagement::Version do
   describe 'relations' do

ee/spec/models/ee/clusters/applications/prometheus_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Clusters::Applications::Prometheus do
   describe 'transition to updating' do

ee/spec/models/ee/list_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe List do
   let(:board) { create(:board) }

ee/spec/models/ee/resource_label_event_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe ResourceLabelEvent, type: :model do
   subject { build(:resource_label_event) }

ee/spec/models/member_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Member, type: :model do
   describe '#notification_service' do

ee/spec/models/packages/maven_metadatum_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Packages::MavenMetadatum, type: :model do
   describe 'relationships' do

ee/spec/models/packages/package_file_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Packages::PackageFile, type: :model do
   describe 'relationships' do

ee/spec/models/packages/package_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Packages::Package, type: :model do
   describe 'relationships' do

ee/spec/models/project_feature_usage_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe ProjectFeatureUsage, type: :model do
   describe '.jira_dvcs_integrations_enabled_count' do

ee/spec/models/project_import_state_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe ProjectImportState, type: :model do
   describe 'Project import job' do

ee/spec/models/project_repository_state_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe ProjectRepositoryState do
   using RSpec::Parameterized::TableSyntax

ee/spec/models/scoped_label_set_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe ScopedLabelSet do
   set(:kv_label1) { create(:label, title: 'key::label1') }

ee/spec/requests/groups/roadmap_controller_spec.rb

 # frozen_string_literal: true
-require 'rails_helper'
+require 'spec_helper'
 
 describe Groups::RoadmapController do
   let(:user) { create(:user) }

ee/spec/requests/jira_routing_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Jira referenced paths', type: :request do
   using RSpec::Parameterized::TableSyntax

ee/spec/requests/projects/issue_links_controller_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe Projects::IssueLinksController do
   let(:user) { create :user }

ee/spec/services/ee/null_notification_service_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe ::EE::NullNotificationService do
   it 'responds to methods implemented by NotificationService' do

ee/spec/services/merge_requests/approval_service_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe MergeRequests::ApprovalService do
   describe '#execute' do

ee/spec/services/merge_requests/remove_approval_service_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe MergeRequests::RemoveApprovalService do
   describe '#execute' do

ee/spec/views/admin/users/index.html.haml_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe 'admin/users/index' do
   let(:should_check_namespace_plan) { false }

ee/spec/workers/geo/batch/project_registry_scheduler_worker_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Geo::Batch::ProjectRegistrySchedulerWorker do
   include ExclusiveLeaseHelpers

ee/spec/workers/geo/batch/project_registry_worker_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Geo::Batch::ProjectRegistryWorker do
   include ::EE::GeoHelpers

ee/spec/workers/geo/metrics_update_worker_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Geo::MetricsUpdateWorker, :geo do
   include ::EE::GeoHelpers

ee/spec/workers/geo/project_sync_worker_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 RSpec.describe Geo::ProjectSyncWorker do
   describe '#perform' do

ee/spec/workers/repository_update_mirror_worker_spec.rb

-require 'rails_helper'
+require 'spec_helper'
 
 describe RepositoryUpdateMirrorWorker do
   describe '#perform' do

spec/controllers/projects/blob_controller_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe Projects::BlobController do
   include ProjectForksHelper

spec/controllers/sent_notifications_controller_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe SentNotificationsController do
   let(:user) { create(:user) }

spec/features/admin/admin_disables_git_access_protocol_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Admin disables Git access protocol', :js do
   include StubENV

spec/features/admin/admin_disables_two_factor_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Admin disables 2FA for a user' do
   it 'successfully', :js do

spec/features/admin/admin_uses_repository_checks_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Admin uses repository checks' do
   include StubENV

spec/features/boards/add_issues_modal_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards add issue modal', :js do
   let(:project) { create(:project, :public) }

spec/features/boards/boards_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards', :js do
   include DragTo

spec/features/boards/issue_ordering_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards', :js do
   include DragTo

spec/features/boards/keyboard_shortcut_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards shortcut', :js do
   context 'issues are enabled' do

spec/features/boards/modal_filter_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards add issue modal filtering', :js do
   let(:project) { create(:project, :public) }

spec/features/boards/multiple_boards_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Multiple Issue Boards', :js do
   set(:user) { create(:user) }

spec/features/boards/new_issue_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards new issue', :js do
   let(:project) { create(:project, :public) }

spec/features/boards/reload_boards_on_browser_back_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Ensure Boards do not show stale data on browser back', :js do
   let(:project) {create(:project, :public)}

spec/features/boards/sidebar_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Issue Boards', :js do
   include BoardHelpers

spec/features/boards/sub_group_project_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Sub-group project issue boards', :js do
   let(:group) { create(:group) }

spec/features/commits/user_uses_quick_actions_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Commit > User uses quick actions', :js do
   include Spec::Support::Helpers::Features::NotesHelpers

spec/features/dashboard/todos/target_state_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Dashboard > Todo target states' do
   let(:user)    { create(:user) }

spec/features/groups/board_sidebar_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Group Issue Boards', :js do
   include BoardHelpers

spec/features/groups/board_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Group Boards' do
   let(:group) { create(:group) }

spec/features/groups/milestone_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Group milestones' do
   let(:group) { create(:group) }

spec/features/groups/user_browse_projects_group_page_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'User browse group projects page' do
   let(:user) { create :user }

spec/features/instance_statistics/cohorts_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Cohorts page' do
   before do

spec/features/instance_statistics/instance_statistics_spec.rb

 # frozen_string_literal: true
 
-require 'rails_helper'
+require 'spec_helper'
 
 describe 'Cohorts page', :js do
   before do