Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
040f3180
Commit
040f3180
authored
Oct 06, 2020
by
Tristan Read
Committed by
Nicolò Maria Mezzopera
Oct 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add hosts field to alert detail table
parent
7b1aab82
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
10 additions
and
0 deletions
+10
-0
app/assets/javascripts/alert_management/graphql/fragments/detail_item.fragment.graphql
...management/graphql/fragments/detail_item.fragment.graphql
+1
-0
app/assets/javascripts/issue_show/components/incidents/graphql/queries/get_alert.graphql
...ow/components/incidents/graphql/queries/get_alert.graphql
+1
-0
app/assets/javascripts/vue_shared/components/alert_details_table.vue
...javascripts/vue_shared/components/alert_details_table.vue
+1
-0
changelogs/unreleased/tr-add-detail-fields-to-table.yml
changelogs/unreleased/tr-add-detail-fields-to-table.yml
+5
-0
spec/frontend/vue_shared/components/alert_details_table_spec.js
...rontend/vue_shared/components/alert_details_table_spec.js
+2
-0
No files found.
app/assets/javascripts/alert_management/graphql/fragments/detail_item.fragment.graphql
View file @
040f3180
...
@@ -10,6 +10,7 @@ fragment AlertDetailItem on AlertManagementAlert {
...
@@ -10,6 +10,7 @@ fragment AlertDetailItem on AlertManagementAlert {
description
description
updatedAt
updatedAt
endedAt
endedAt
hosts
details
details
runbook
runbook
todos
{
todos
{
...
...
app/assets/javascripts/issue_show/components/incidents/graphql/queries/get_alert.graphql
View file @
040f3180
...
@@ -13,6 +13,7 @@ query getAlert($iid: String!, $fullPath: ID!) {
...
@@ -13,6 +13,7 @@ query getAlert($iid: String!, $fullPath: ID!) {
service
service
description
description
endedAt
endedAt
hosts
details
details
}
}
}
}
...
...
app/assets/javascripts/vue_shared/components/alert_details_table.vue
View file @
040f3180
...
@@ -23,6 +23,7 @@ const allowedFields = [
...
@@ -23,6 +23,7 @@ const allowedFields = [
'
endedAt
'
,
'
endedAt
'
,
'
details
'
,
'
details
'
,
'
environment
'
,
'
environment
'
,
'
hosts
'
,
];
];
const
isAllowed
=
fieldName
=>
allowedFields
.
includes
(
fieldName
);
const
isAllowed
=
fieldName
=>
allowedFields
.
includes
(
fieldName
);
...
...
changelogs/unreleased/tr-add-detail-fields-to-table.yml
0 → 100644
View file @
040f3180
---
title
:
Add hosts field to alert detail table
merge_request
:
43087
author
:
type
:
changed
spec/frontend/vue_shared/components/alert_details_table_spec.js
View file @
040f3180
...
@@ -14,6 +14,7 @@ const mockAlert = {
...
@@ -14,6 +14,7 @@ const mockAlert = {
assignees
:
{
nodes
:
[]
},
assignees
:
{
nodes
:
[]
},
notes
:
{
nodes
:
[]
},
notes
:
{
nodes
:
[]
},
todos
:
{
nodes
:
[]
},
todos
:
{
nodes
:
[]
},
hosts
:
[
'
host1
'
,
'
host2
'
],
__typename
:
'
AlertManagementAlert
'
,
__typename
:
'
AlertManagementAlert
'
,
};
};
...
@@ -83,6 +84,7 @@ describe('AlertDetails', () => {
...
@@ -83,6 +84,7 @@ describe('AlertDetails', () => {
expect
(
findTableField
(
fields
,
'
Severity
'
).
exists
()).
toBe
(
true
);
expect
(
findTableField
(
fields
,
'
Severity
'
).
exists
()).
toBe
(
true
);
expect
(
findTableField
(
fields
,
'
Status
'
).
exists
()).
toBe
(
true
);
expect
(
findTableField
(
fields
,
'
Status
'
).
exists
()).
toBe
(
true
);
expect
(
findTableField
(
fields
,
'
Environment
'
).
exists
()).
toBe
(
true
);
expect
(
findTableField
(
fields
,
'
Environment
'
).
exists
()).
toBe
(
true
);
expect
(
findTableField
(
fields
,
'
Hosts
'
).
exists
()).
toBe
(
true
);
});
});
it
(
'
should not show disallowed alert fields
'
,
()
=>
{
it
(
'
should not show disallowed alert fields
'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment