Commit 06e3a9c3 authored by Sean Carroll's avatar Sean Carroll
parent a6303996
...@@ -16,7 +16,7 @@ module Gitlab ...@@ -16,7 +16,7 @@ module Gitlab
command = BASE_COMMAND.dup command = BASE_COMMAND.dup
config.each { |k, v| command.concat(" --#{k.to_s.dasherize} \"#{v}\"") } config.each { |k, v| command.concat(" --#{k.to_s.dasherize} \"#{v}\"") }
command [command]
end end
end end
end end
......
...@@ -19,7 +19,7 @@ describe Gitlab::Ci::Build::Releaser do ...@@ -19,7 +19,7 @@ describe Gitlab::Ci::Build::Releaser do
end end
it 'generates the script' do it 'generates the script' do
expect(subject).to eq('release-cli create --name "Release $CI_COMMIT_SHA" --description "Created using the release-cli $EXTRA_DESCRIPTION" --tag-name "release-$CI_COMMIT_SHA" --ref "$CI_COMMIT_SHA"') expect(subject).to eq(['release-cli create --name "Release $CI_COMMIT_SHA" --description "Created using the release-cli $EXTRA_DESCRIPTION" --tag-name "release-$CI_COMMIT_SHA" --ref "$CI_COMMIT_SHA"'])
end end
end end
...@@ -43,7 +43,7 @@ describe Gitlab::Ci::Build::Releaser do ...@@ -43,7 +43,7 @@ describe Gitlab::Ci::Build::Releaser do
end end
it 'generates the script' do it 'generates the script' do
expect(subject).to eq(result) expect(subject).to eq([result])
end end
end end
end end
......
...@@ -62,7 +62,7 @@ describe Gitlab::Ci::Build::Step do ...@@ -62,7 +62,7 @@ describe Gitlab::Ci::Build::Step do
let(:job) { create(:ci_build, :release_options) } let(:job) { create(:ci_build, :release_options) }
it 'returns the release-cli command line' do it 'returns the release-cli command line' do
expect(subject.script).to eq("release-cli create --name \"Release $CI_COMMIT_SHA\" --description \"Created using the release-cli $EXTRA_DESCRIPTION\" --tag-name \"release-$CI_COMMIT_SHA\" --ref \"$CI_COMMIT_SHA\"") expect(subject.script).to eq(["release-cli create --name \"Release $CI_COMMIT_SHA\" --description \"Created using the release-cli $EXTRA_DESCRIPTION\" --tag-name \"release-$CI_COMMIT_SHA\" --ref \"$CI_COMMIT_SHA\""])
end end
end end
......
...@@ -668,7 +668,7 @@ describe API::Runner, :clean_gitlab_redis_shared_state do ...@@ -668,7 +668,7 @@ describe API::Runner, :clean_gitlab_redis_shared_state do
{ {
"name" => "release", "name" => "release",
"script" => "script" =>
"release-cli create --ref \"$CI_COMMIT_SHA\" --name \"Release $CI_COMMIT_SHA\" --tag-name \"release-$CI_COMMIT_SHA\" --description \"Created using the release-cli $EXTRA_DESCRIPTION\"", ["release-cli create --ref \"$CI_COMMIT_SHA\" --name \"Release $CI_COMMIT_SHA\" --tag-name \"release-$CI_COMMIT_SHA\" --description \"Created using the release-cli $EXTRA_DESCRIPTION\""],
"timeout" => 3600, "timeout" => 3600,
"when" => "on_success", "when" => "on_success",
"allow_failure" => false "allow_failure" => false
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment