Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
087eb951
Commit
087eb951
authored
Oct 10, 2018
by
Evan Read
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix broken link
Also includes some basic fixes to Markdown to make it adhere to styleguide.
parent
f9bedcfc
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
57 additions
and
52 deletions
+57
-52
doc/development/fe_guide/style_guide_js.md
doc/development/fe_guide/style_guide_js.md
+57
-52
No files found.
doc/development/fe_guide/style_guide_js.md
View file @
087eb951
# Style guides and linting
# Style guides and linting
See the relevant style guides for our guidelines and for information on linting:
See the relevant style guides for our guidelines and for information on linting:
## JavaScript
## JavaScript
We defer to
[
Airbnb
][
airbnb-js-style-guide
]
on most style-related
We defer to
[
Airbnb
][
airbnb-js-style-guide
]
on most style-related
conventions and enforce them with eslint.
conventions and enforce them with eslint.
See
[
our current .eslintrc
]
[
eslintrc
]
for specific rules and patterns.
See
[
our current .eslintrc
]
(
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc.yml
)
for specific rules and patterns.
### Common
### Common
...
@@ -299,10 +301,12 @@ Do not use them anymore and feel free to remove them when refactoring legacy cod
...
@@ -299,10 +301,12 @@ Do not use them anymore and feel free to remove them when refactoring legacy cod
### Vue.js
### Vue.js
#### `eslint-vue-plugin`
#### `eslint-vue-plugin`
We default to
[
eslint-vue-plugin
][
eslint-plugin-vue
]
, with the
`plugin:vue/recommended`
.
We default to
[
eslint-vue-plugin
][
eslint-plugin-vue
]
, with the
`plugin:vue/recommended`
.
Please check this
[
rules
][
eslint-plugin-vue-rules
]
for more documentation.
Please check this
[
rules
][
eslint-plugin-vue-rules
]
for more documentation.
#### Basic Rules
#### Basic Rules
1.
The service has it's own file
1.
The service has it's own file
1.
The store has it's own file
1.
The store has it's own file
1.
Use a function in the bundle file to instantiate the Vue component:
1.
Use a function in the bundle file to instantiate the Vue component:
...
@@ -387,6 +391,7 @@ Please check this [rules][eslint-plugin-vue-rules] for more documentation.
...
@@ -387,6 +391,7 @@ Please check this [rules][eslint-plugin-vue-rules] for more documentation.
[
#34371
]:
https://gitlab.com/gitlab-org/gitlab-ce/issues/34371
[
#34371
]:
https://gitlab.com/gitlab-org/gitlab-ce/issues/34371
#### Alignment
#### Alignment
1.
Follow these alignment styles for the template method:
1.
Follow these alignment styles for the template method:
1.
With more than one attribute, all attributes should be on a new line:
1.
With more than one attribute, all attributes should be on a new line:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment