Merge branch '347285-sort-package-registry-by-published-by-default' into 'master'

Sort package list by Published and persist user selection

See merge request gitlab-org/gitlab!78386

app/assets/javascripts/packages_and_registries/package_registry/components/list/package_search.vue

@@ -9,6 +9,8 @@ import {
   FILTERED_SEARCH_TERM,
   FILTERED_SEARCH_TYPE,
 } from '~/packages_and_registries/shared/constants';
+import { LIST_KEY_CREATED_AT } from '~/packages_and_registries/package_registry/constants';
+import LocalStorageSync from '~/vue_shared/components/local_storage_sync.vue';
 import PackageTypeToken from './tokens/package_type_token.vue';
 
 export default {
@@ -22,13 +24,13 @@ export default {
       operators: OPERATOR_IS_ONLY,
     },
   ],
-  components: { RegistrySearch, UrlSync },
+  components: { RegistrySearch, UrlSync, LocalStorageSync },
   inject: ['isGroupPage'],
   data() {
     return {
       filters: [],
       sorting: {
-        orderBy: 'name',
+        orderBy: LIST_KEY_CREATED_AT,
         sort: 'desc',
       },
       mountRegistrySearch: false,
@@ -94,6 +96,12 @@ export default {
 </script>
 
 <template>
+  <local-storage-sync
+    storage-key="package_registry_list_sorting"
+    :value="sorting"
+    as-json
+    @input="updateSorting"
+  >
     <url-sync>
       <template #default="{ updateQuery }">
         <registry-search
@@ -109,4 +117,5 @@ export default {
         />
       </template>
     </url-sync>
+  </local-storage-sync>
 </template>

spec/frontend/packages_and_registries/package_registry/components/list/packages_search_spec.js

@@ -5,7 +5,10 @@ import component from '~/packages_and_registries/package_registry/components/lis
 import PackageTypeToken from '~/packages_and_registries/package_registry/components/list/tokens/package_type_token.vue';
 import RegistrySearch from '~/vue_shared/components/registry/registry_search.vue';
 import UrlSync from '~/vue_shared/components/url_sync.vue';
+import LocalStorageSync from '~/vue_shared/components/local_storage_sync.vue';
 import { useMockLocationHelper } from 'helpers/mock_window_location_helper';
+import { LIST_KEY_CREATED_AT } from '~/packages_and_registries/package_registry/constants';
+
 import { getQueryParams, extractFilterAndSorting } from '~/packages_and_registries/shared/utils';
 
 jest.mock('~/packages_and_registries/shared/utils');
@@ -22,6 +25,7 @@ describe('Package Search', () => {
 
   const findRegistrySearch = () => wrapper.findComponent(RegistrySearch);
   const findUrlSync = () => wrapper.findComponent(UrlSync);
+  const findLocalStorageSync = () => wrapper.findComponent(LocalStorageSync);
 
   const mountComponent = (isGroupPage = false) => {
     wrapper = shallowMountExtended(component, {
@@ -32,6 +36,7 @@ describe('Package Search', () => {
       },
       stubs: {
         UrlSync,
+        LocalStorageSync,
       },
     });
   };
@@ -64,6 +69,19 @@ describe('Package Search', () => {
     expect(findUrlSync().exists()).toBe(true);
   });
 
+  it('has a LocalStorageSync component', () => {
+    mountComponent();
+
+    expect(findLocalStorageSync().props()).toMatchObject({
+      asJson: true,
+      storageKey: 'package_registry_list_sorting',
+      value: {
+        orderBy: LIST_KEY_CREATED_AT,
+        sort: 'desc',
+      },
+    });
+  });
+
   it.each`
     isGroupPage | page
     ${false}    | ${'project'}
@@ -92,7 +110,7 @@ describe('Package Search', () => {
 
     await nextTick();
 
-    expect(findRegistrySearch().props('sorting')).toEqual({ sort: 'foo', orderBy: 'name' });
+    expect(findRegistrySearch().props('sorting')).toEqual({ sort: 'foo', orderBy: 'created_at' });
 
     // there is always a first call on mounted that emits up default values
     expect(wrapper.emitted('update')[1]).toEqual([
@@ -101,7 +119,7 @@ describe('Package Search', () => {
           packageName: '',
           packageType: undefined,
         },
-        sort: 'NAME_FOO',
+        sort: 'CREATED_FOO',
       },
     ]);
   });
@@ -133,7 +151,7 @@ describe('Package Search', () => {
           packageName: '',
           packageType: undefined,
         },
-        sort: 'NAME_DESC',
+        sort: 'CREATED_DESC',
       },
     ]);
   });