Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0d72eb15
Commit
0d72eb15
authored
Nov 19, 2019
by
shampton
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add feature flag instruction
Provide details on how to enable the feature flag.
parent
7b157647
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
8 deletions
+14
-8
doc/ci/review_apps/index.md
doc/ci/review_apps/index.md
+14
-8
No files found.
doc/ci/review_apps/index.md
View file @
0d72eb15
...
@@ -163,8 +163,12 @@ that spawned the Review App.
...
@@ -163,8 +163,12 @@ that spawned the Review App.
### Configuring Visual Reviews
### Configuring Visual Reviews
Ensure that the
`anonymous_visual_review_feedback`
feature flag is enabled on
Ensure that the
`anonymous_visual_review_feedback`
feature flag is enabled.
your GitLab instance or project if you are self-hosting.
Administrators can enable with a Rails console as follows:
```
ruby
Feature
.
enabled
(
:anonymous_visual_review_feedback
)
```
The feedback form is served through a script you add to pages in your Review App.
The feedback form is served through a script you add to pages in your Review App.
If you have
[
Developer permissions
](
../../user/permissions.md
)
to the project,
If you have
[
Developer permissions
](
../../user/permissions.md
)
to the project,
...
@@ -226,14 +230,16 @@ to make this process even easier.
...
@@ -226,14 +230,16 @@ to make this process even easier.
### Determining merge request ID
### Determining merge request ID
The merge request ID can be automatically determined through the script tag
The visual review tools retrieve the merge request ID from the
`data-merge-request-id`
via the data attribute
`data-merge-request-id`
.
data attribute included in the
`script`
HTML tag used to add the visual review tools
to your review app.
There are three ways to provide a merge request ID to a Visual Review app:
After determining the ID for the merge request to link to a visual review app, you
can supply the ID by either:
-
By hardcoding it in the script tag via the data attribute
`data-merge-request-id`
-
Hardcoding it in the script tag via the data attribute
`data-merge-request-id`
of the app.
-
Dynamically adding the
`data-merge-request-id`
value during
build
.
-
Dynamically adding the
`data-merge-request-id`
value during
the build of the app
.
-
Supplying it manually through the visual review form.
-
Supplying it manually through the visual review form
in the app
.
### Using Visual Reviews
### Using Visual Reviews
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment