Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
0e30f242
Commit
0e30f242
authored
Nov 11, 2019
by
Brian T
Committed by
Martin Wortschack
Nov 11, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix unable to expand or collapse files in merge request by clicking caret
parent
e3b83f06
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
1 deletion
+19
-1
app/assets/javascripts/vue_shared/components/icon.vue
app/assets/javascripts/vue_shared/components/icon.vue
+1
-1
changelogs/unreleased/25188-unable-to-expand-collapse-files-in-merge-request-by-clicking-caret.yml
...and-collapse-files-in-merge-request-by-clicking-caret.yml
+5
-0
spec/javascripts/vue_shared/components/icon_spec.js
spec/javascripts/vue_shared/components/icon_spec.js
+13
-0
No files found.
app/assets/javascripts/vue_shared/components/icon.vue
View file @
0e30f242
...
...
@@ -61,7 +61,7 @@ export default {
</
script
>
<
template
>
<svg
:class=
"[iconSizeClass, iconTestClass]"
aria-hidden=
"true"
>
<svg
:class=
"[iconSizeClass, iconTestClass]"
aria-hidden=
"true"
v-on=
"$listeners"
>
<use
v-bind=
"
{ 'xlink:href': spriteHref }" />
</svg>
</
template
>
changelogs/unreleased/25188-unable-to-expand-collapse-files-in-merge-request-by-clicking-caret.yml
0 → 100644
View file @
0e30f242
---
title
:
Fix unable to expand or collapse files in merge request by clicking caret
merge_request
:
19222
author
:
Brian T
type
:
fixed
spec/javascripts/vue_shared/components/icon_spec.js
View file @
0e30f242
import
Vue
from
'
vue
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
mountComponent
from
'
spec/helpers/vue_mount_component_helper
'
;
import
{
mount
}
from
'
@vue/test-utils
'
;
describe
(
'
Sprite Icon Component
'
,
function
()
{
describe
(
'
Initialization
'
,
function
()
{
...
...
@@ -57,4 +58,16 @@ describe('Sprite Icon Component', function() {
expect
(
Icon
.
props
.
name
.
validator
(
'
commit
'
)).
toBe
(
true
);
});
});
it
(
'
should call registered listeners when they are triggered
'
,
()
=>
{
const
clickHandler
=
jasmine
.
createSpy
(
'
clickHandler
'
);
const
wrapper
=
mount
(
Icon
,
{
propsData
:
{
name
:
'
commit
'
},
listeners
:
{
click
:
clickHandler
},
});
wrapper
.
find
(
'
svg
'
).
trigger
(
'
click
'
);
expect
(
clickHandler
).
toHaveBeenCalled
();
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment