Merge branch '291001-finding-vuln-state-inconsistecy' into 'master'

Include `detected`  state vulnerability check for findings

See merge request gitlab-org/gitlab!55806

ee/app/models/vulnerabilities/finding.rb

@@ -123,7 +123,7 @@ module Vulnerabilities
     def state
       return 'dismissed' if dismissal_feedback.present?
 
-      if vulnerability.nil?
+      if vulnerability.nil? || vulnerability.detected?
         'detected'
       elsif vulnerability.resolved?
         'resolved'

ee/changelogs/unreleased/291001-finding-vuln-state-inconsistecy.yml

+---
+title: Include detected vulnerability in finding state check
+merge_request: 55806
+author:
+type: added

ee/spec/models/vulnerabilities/finding_spec.rb

@@ -655,6 +655,7 @@ RSpec.describe Vulnerabilities::Finding do
     let(:confirmed_finding) { create(:vulnerabilities_finding, :confirmed) }
     let(:resolved_finding) { create(:vulnerabilities_finding, :resolved) }
     let(:dismissed_finding) { create(:vulnerabilities_finding, :dismissed) }
+    let(:detected_finding) { create(:vulnerabilities_finding, :detected) }
     let(:finding_with_issue) { create(:vulnerabilities_finding, :with_issue_feedback) }
 
     it 'returns the expected state for a unresolved finding' do
@@ -673,6 +674,10 @@ RSpec.describe Vulnerabilities::Finding do
       expect(dismissed_finding.state).to eq 'dismissed'
     end
 
+    it 'returns the expected state for a detected finding' do
+      expect(detected_finding.state).to eq 'detected'
+    end
+
     context 'when a vulnerability present for a dismissed finding' do
       before do
         create(:vulnerability, project: dismissed_finding.project, findings: [dismissed_finding])