Merge branch '4582-fix-incorrect-neutral-count' into 'master'

Fix neutralCount computation to prevent negative values

Closes #4582

See merge request gitlab-org/gitlab-ee!4044

app/assets/javascripts/vue_shared/components/stacked_progress_bar.vue

@@ -37,6 +37,9 @@ export default {
     },
   },
   computed: {
+    neutralCount() {
+      return this.totalCount - this.successCount - this.failureCount;
+    },
     successPercent() {
       return this.getPercent(this.successCount);
     },
@@ -56,14 +59,13 @@ export default {
       return this.getTooltip(this.failureLabel, this.failureCount);
     },
     neutralPercent() {
-      return 100 - this.successPercent - this.failurePercent;
+      return this.getPercent(this.neutralCount);
     },
     neutralBarStyle() {
       return this.barStyle(this.neutralPercent);
     },
     neutralTooltip() {
-      const neutralCount = this.totalCount - this.successCount - this.failureCount;
-      return this.getTooltip(this.neutralLabel, neutralCount);
+      return this.getTooltip(this.neutralLabel, this.neutralCount);
     },
   },
   methods: {

changelogs/unreleased-ee/4582-fix-incorrect-neutral-count.yml

+---
+title: Fix neutralCount computation to prevent negative values
+merge_request: 4044
+author:
+type: fixed

spec/javascripts/vue_shared/components/stacked_progress_bar_spec.js

@@ -29,6 +29,14 @@ describe('StackedProgressBarComponent', () => {
     vm.$destroy();
   });
 
+  describe('computed', () => {
+    describe('neutralCount', () => {
+      it('returns neutralCount based on totalCount, successCount and failureCount', () => {
+        expect(vm.neutralCount).toBe(5); // 20 - 10 - 5
+      });
+    });
+  });
+
   describe('methods', () => {
     describe('getPercent', () => {
       it('returns percentage from provided count based on `totalCount`', () => {