Remove boards_with_swimlanes feature flag

Review feedback

app/assets/javascripts/boards/components/modal/filters.js

 import FilteredSearchBoards from '../../filtered_search_boards';
 import FilteredSearchContainer from '../../../filtered_search/container';
+import vuexstore from '~/boards/stores';
 
 export default {
   name: 'modal-filters',
@@ -12,7 +13,7 @@ export default {
   mounted() {
     FilteredSearchContainer.container = this.$el;
 
-    this.filteredSearch = new FilteredSearchBoards(this.store);
+    this.filteredSearch = new FilteredSearchBoards(this.store, vuexstore);
     this.filteredSearch.setup();
     this.filteredSearch.removeTokens();
     this.filteredSearch.handleInputPlaceholder();

app/assets/javascripts/boards/filtered_search_boards.js

@@ -4,7 +4,7 @@ import FilteredSearchContainer from '../filtered_search/container';
 import boardsStore from './stores/boards_store';
 
 export default class FilteredSearchBoards extends FilteredSearchManager {
-  constructor(store, updateUrl = false, cantEdit = [], vuexstore = {}) {
+  constructor(store, vuexstore, updateUrl = false, cantEdit = []) {
     super({
       page: 'boards',
       isGroupDecendent: true,

app/assets/javascripts/boards/index.js

@@ -154,9 +154,9 @@ export default () => {
     mounted() {
       this.filterManager = new FilteredSearchBoards(
         boardsStore.filter,
+        store,
         true,
         boardsStore.cantEdit,
-        store,
       );
       this.filterManager.setup();
 
@@ -200,7 +200,7 @@ export default () => {
           this.resetEpics();
           this.resetIssues();
           this.fetchEpicsSwimlanes({});
-        } else if (gon.features.graphqlBoardLists && !this.isSwimlanesOn) {
+        } else if (gon.features.graphqlBoardLists) {
           this.fetchLists();
           this.resetIssues();
         }

app/assets/javascripts/boards/stores/getters.js

@@ -4,9 +4,7 @@ import { inactiveId } from '../constants';
 export default {
   labelToggleState: state => (state.isShowingLabels ? 'on' : 'off'),
   isSidebarOpen: state => state.activeId !== inactiveId,
-  isSwimlanesOn: () => {
-    return false;
-  },
+  isSwimlanesOn: () => false,
   getIssueById: state => id => {
     return state.issues[id] || {};
   },

ee/app/assets/javascripts/boards/stores/getters.js

@@ -4,11 +4,7 @@ export default {
   ...gettersCE,
 
   isSwimlanesOn: state => {
-    if (!gon?.features?.swimlanes) {
-      return false;
-    }
-
-    return state.isShowingEpicsSwimlanes;
+    return Boolean(gon?.features?.swimlanes && state.isShowingEpicsSwimlanes);
   },
   getIssuesByEpic: (state, getters) => (listId, epicId) => {
     return getters.getIssuesByList(listId).filter(issue => issue.epic && issue.epic.id === epicId);