Commit 1711a384 authored by Douwe Maan's avatar Douwe Maan Committed by Fatih Acet

Prevent “This merge request contains merge conflicts” from being shown after...

Prevent “This merge request contains merge conflicts” from being shown after resolution because of slow background workers
parent 8dba8e2d
...@@ -53,7 +53,7 @@ ...@@ -53,7 +53,7 @@
return function(data) { return function(data) {
var callback, urlSuffix; var callback, urlSuffix;
if (data.state === "merged") { if (data.state === "merged") {
urlSuffix = deleteSourceBranch ? '?delete_source=true' : ''; urlSuffix = deleteSourceBranch ? '?deleted_source_branch=true' : '';
return window.location.href = window.location.pathname + urlSuffix; return window.location.href = window.location.pathname + urlSuffix;
} else if (data.merge_error) { } else if (data.merge_error) {
return $('.mr-widget-body').html("<h4>" + data.merge_error + "</h4>"); return $('.mr-widget-body').html("<h4>" + data.merge_error + "</h4>");
......
...@@ -168,7 +168,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController ...@@ -168,7 +168,7 @@ class Projects::MergeRequestsController < Projects::ApplicationController
flash[:conflicts_message] = 'Merge conflicts resolved.' flash[:conflicts_message] = 'Merge conflicts resolved.'
flash.keep flash.keep
render json: { redirect_to: namespace_project_merge_request_url(@project.namespace, @project, @merge_request) } render json: { redirect_to: namespace_project_merge_request_url(@project.namespace, @project, @merge_request, resolved_conflicts: true) }
rescue Gitlab::Conflict::File::MissingResolution => e rescue Gitlab::Conflict::File::MissingResolution => e
render status: :bad_request, json: { message: e.message } render status: :bad_request, json: { message: e.message }
end end
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
- if @merge_request.merge_event - if @merge_request.merge_event
by #{link_to_member(@project, @merge_request.merge_event.author, avatar: true)} by #{link_to_member(@project, @merge_request.merge_event.author, avatar: true)}
#{time_ago_with_tooltip(@merge_request.merge_event.created_at)} #{time_ago_with_tooltip(@merge_request.merge_event.created_at)}
- if !@merge_request.source_branch_exists? || (params[:delete_source] == 'true') - if !@merge_request.source_branch_exists? || params[:deleted_source_branch]
%p %p
The changes were merged into The changes were merged into
#{link_to @merge_request.target_branch, namespace_project_commits_path(@project.namespace, @project, @merge_request.target_branch), class: "label-branch"}. #{link_to @merge_request.target_branch, namespace_project_commits_path(@project.namespace, @project, @merge_request.target_branch), class: "label-branch"}.
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
= render 'projects/merge_requests/widget/open/missing_branch' = render 'projects/merge_requests/widget/open/missing_branch'
- elsif @merge_request.unchecked? - elsif @merge_request.unchecked?
= render 'projects/merge_requests/widget/open/check' = render 'projects/merge_requests/widget/open/check'
- elsif @merge_request.cannot_be_merged? - elsif @merge_request.cannot_be_merged? && !params[:resolved_conflicts]
= render 'projects/merge_requests/widget/open/conflicts' = render 'projects/merge_requests/widget/open/conflicts'
- elsif @merge_request.work_in_progress? - elsif @merge_request.work_in_progress?
= render 'projects/merge_requests/widget/open/wip' = render 'projects/merge_requests/widget/open/wip'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment