Commit 1944c395 authored by Ezekiel Kigbo's avatar Ezekiel Kigbo

Minor review comments

parent 1757a445
...@@ -11,7 +11,6 @@ export default { ...@@ -11,7 +11,6 @@ export default {
directives: { directives: {
GlModalDirective, GlModalDirective,
}, },
props: {},
data() { data() {
return { return {
name: '', name: '',
...@@ -26,11 +25,9 @@ export default { ...@@ -26,11 +25,9 @@ export default {
</script> </script>
<template> <template>
<gl-form> <gl-form>
<gl-button <gl-button v-gl-modal-directive="'create-value-stream-modal'">{{
v-gl-modal-directive="'create-value-stream-modal'" __('Create new value stream')
data-testid="create-value-stream" }}</gl-button>
>{{ __('Create new value stream') }}</gl-button
>
<gl-modal <gl-modal
modal-id="create-value-stream-modal" modal-id="create-value-stream-modal"
:title="__('Value Stream Name')" :title="__('Value Stream Name')"
......
...@@ -5,12 +5,8 @@ import ValueStreamSelect from 'ee/analytics/cycle_analytics/components/value_str ...@@ -5,12 +5,8 @@ import ValueStreamSelect from 'ee/analytics/cycle_analytics/components/value_str
describe('ValueStreamSelect', () => { describe('ValueStreamSelect', () => {
let wrapper = null; let wrapper = null;
function createComponent() { const createComponent = () => shallowMount(ValueStreamSelect, {});
return shallowMount(ValueStreamSelect, {});
}
const findModal = () => wrapper.find(GlModal); const findModal = () => wrapper.find(GlModal);
const submitButtonDisabledState = () => findModal().props('actionPrimary').attributes[1].disabled; const submitButtonDisabledState = () => findModal().props('actionPrimary').attributes[1].disabled;
beforeEach(() => { beforeEach(() => {
...@@ -27,9 +23,9 @@ describe('ValueStreamSelect', () => { ...@@ -27,9 +23,9 @@ describe('ValueStreamSelect', () => {
}); });
describe('with valid fields', () => { describe('with valid fields', () => {
beforeEach(() => { beforeEach(async () => {
wrapper = createComponent(); wrapper = createComponent();
wrapper.setData({ name: 'Cool stream' }); await wrapper.setData({ name: 'Cool stream' });
}); });
it('submit button is enabled', () => { it('submit button is enabled', () => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment