Merge branch 'fix/disable-gitaly-post-receive-pack' into 'master'

Disable support for Gitaly PostReceivePack

See merge request !10444

lib/gitlab/workhorse.rb

@@ -35,7 +35,8 @@ module Gitlab
 
           feature_enabled = case action.to_s
                             when 'git_receive_pack'
-                              Gitlab::GitalyClient.feature_enabled?(:post_receive_pack)
+                              # Disabled for now, see https://gitlab.com/gitlab-org/gitaly/issues/172
+                              false
                             when 'git_upload_pack'
                               Gitlab::GitalyClient.feature_enabled?(:post_upload_pack)
                             when 'info_refs'

spec/lib/gitlab/workhorse_spec.rb

@@ -207,12 +207,9 @@ describe Gitlab::Workhorse, lib: true do
         expect(subject).to include(repo_param)
       end
 
-      {
-        git_receive_pack: :post_receive_pack,
-        git_upload_pack: :post_upload_pack
-      }.each do |action_name, feature_flag|
-        context "when #{action_name} action is passed" do
-          let(:action) { action_name }
+      context "when git_upload_pack action is passed" do
+        let(:action) { 'git_upload_pack' }
+        let(:feature_flag) { :post_upload_pack }
 
         context 'when action is enabled by feature flag' do
           it 'includes Gitaly params in the returned value' do
@@ -230,6 +227,11 @@ describe Gitlab::Workhorse, lib: true do
           end
         end
       end
+
+      context "when git_receive_pack action is passed" do
+        let(:action) { 'git_receive_pack' }
+
+        it { expect(subject).not_to include(gitaly_params) }
       end
 
       context "when info_refs action is passed" do