Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
1de6c1d2
Commit
1de6c1d2
authored
Oct 21, 2019
by
Illya Klymov
Committed by
Clement Ho
Oct 21, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Refactor stage_spec to Jest
* Switches to Jest for stage_spec * Uses snapshots to simplify test code
parent
50e51888
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
149 additions
and
96 deletions
+149
-96
app/assets/javascripts/ide/components/jobs/stage.vue
app/assets/javascripts/ide/components/jobs/stage.vue
+2
-1
spec/frontend/ide/components/jobs/__snapshots__/stage_spec.js.snap
...tend/ide/components/jobs/__snapshots__/stage_spec.js.snap
+61
-0
spec/frontend/ide/components/jobs/stage_spec.js
spec/frontend/ide/components/jobs/stage_spec.js
+86
-0
spec/javascripts/ide/components/jobs/stage_spec.js
spec/javascripts/ide/components/jobs/stage_spec.js
+0
-95
No files found.
app/assets/javascripts/ide/components/jobs/stage.vue
View file @
1de6c1d2
...
...
@@ -58,6 +58,7 @@ export default {
<
template
>
<div
class=
"ide-stage card prepend-top-default"
>
<div
ref=
"cardHeader"
:class=
"
{
'border-bottom-0': stage.isCollapsed,
}"
...
...
@@ -79,7 +80,7 @@ export default {
</div>
<icon
:name=
"collapseIcon"
class=
"ide-stage-collapse-icon"
/>
</div>
<div
v-show=
"!stage.isCollapsed"
class=
"card-body"
>
<div
v-show=
"!stage.isCollapsed"
ref=
"jobList"
class=
"card-body"
>
<gl-loading-icon
v-if=
"showLoadingIcon"
/>
<template
v-else
>
<item
v-for=
"job in stage.jobs"
:key=
"job.id"
:job=
"job"
@
clickViewLog=
"clickViewLog"
/>
...
...
spec/frontend/ide/components/jobs/__snapshots__/stage_spec.js.snap
0 → 100644
View file @
1de6c1d2
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`IDE pipeline stage renders stage details & icon 1`] = `
<div
class="ide-stage card prepend-top-default"
>
<div
class="card-header"
>
<ciicon-stub
cssclasses=""
size="24"
status="[object Object]"
/>
<strong
class="prepend-left-8 ide-stage-title"
data-container="body"
data-original-title=""
title=""
>
build
</strong>
<div
class="append-right-8 prepend-left-4"
>
<span
class="badge badge-pill"
>
4
</span>
</div>
<icon-stub
class="ide-stage-collapse-icon"
name="angle-down"
size="16"
/>
</div>
<div
class="card-body"
>
<item-stub
job="[object Object]"
/>
<item-stub
job="[object Object]"
/>
<item-stub
job="[object Object]"
/>
<item-stub
job="[object Object]"
/>
</div>
</div>
`;
spec/frontend/ide/components/jobs/stage_spec.js
0 → 100644
View file @
1de6c1d2
import
{
shallowMount
}
from
'
@vue/test-utils
'
;
import
{
GlLoadingIcon
}
from
'
@gitlab/ui
'
;
import
Stage
from
'
~/ide/components/jobs/stage.vue
'
;
import
Item
from
'
~/ide/components/jobs/item.vue
'
;
import
{
stages
,
jobs
}
from
'
../../mock_data
'
;
describe
(
'
IDE pipeline stage
'
,
()
=>
{
let
wrapper
;
const
defaultProps
=
{
stage
:
{
...
stages
[
0
],
id
:
0
,
dropdownPath
:
stages
[
0
].
dropdown_path
,
jobs
:
[...
jobs
],
isLoading
:
false
,
isCollapsed
:
false
,
},
};
const
findHeader
=
()
=>
wrapper
.
find
({
ref
:
'
cardHeader
'
});
const
findJobList
=
()
=>
wrapper
.
find
({
ref
:
'
jobList
'
});
const
createComponent
=
props
=>
{
wrapper
=
shallowMount
(
Stage
,
{
propsData
:
{
...
defaultProps
,
...
props
,
},
sync
:
false
,
});
};
afterEach
(()
=>
{
wrapper
.
destroy
();
wrapper
=
null
;
});
it
(
'
emits fetch event when mounted
'
,
()
=>
{
createComponent
();
expect
(
wrapper
.
emitted
().
fetch
).
toBeDefined
();
});
it
(
'
renders loading icon when no jobs and isLoading is true
'
,
()
=>
{
createComponent
({
stage
:
{
...
defaultProps
.
stage
,
isLoading
:
true
,
jobs
:
[]
},
});
expect
(
wrapper
.
find
(
GlLoadingIcon
).
exists
()).
toBe
(
true
);
});
it
(
'
emits toggleCollaped event with stage id when clicking header
'
,
()
=>
{
const
id
=
5
;
createComponent
({
stage
:
{
...
defaultProps
.
stage
,
id
}
});
findHeader
().
trigger
(
'
click
'
);
expect
(
wrapper
.
emitted
().
toggleCollapsed
[
0
][
0
]).
toBe
(
id
);
});
it
(
'
emits clickViewLog entity with job
'
,
()
=>
{
const
[
job
]
=
defaultProps
.
stage
.
jobs
;
createComponent
();
wrapper
.
findAll
(
Item
)
.
at
(
0
)
.
vm
.
$emit
(
'
clickViewLog
'
,
job
);
expect
(
wrapper
.
emitted
().
clickViewLog
[
0
][
0
]).
toBe
(
job
);
});
it
(
'
renders stage details & icon
'
,
()
=>
{
createComponent
();
expect
(
wrapper
.
element
).
toMatchSnapshot
();
});
describe
(
'
when collapsed
'
,
()
=>
{
beforeEach
(()
=>
{
createComponent
({
stage
:
{
...
defaultProps
.
stage
,
isCollapsed
:
true
}
});
});
it
(
'
does not render job list
'
,
()
=>
{
expect
(
findJobList
().
isVisible
()).
toBe
(
false
);
});
it
(
'
sets border bottom class
'
,
()
=>
{
expect
(
findHeader
().
classes
(
'
border-bottom-0
'
)).
toBe
(
true
);
});
});
});
spec/javascripts/ide/components/jobs/stage_spec.js
deleted
100644 → 0
View file @
50e51888
import
Vue
from
'
vue
'
;
import
Stage
from
'
~/ide/components/jobs/stage.vue
'
;
import
{
stages
,
jobs
}
from
'
../../mock_data
'
;
describe
(
'
IDE pipeline stage
'
,
()
=>
{
const
Component
=
Vue
.
extend
(
Stage
);
let
vm
;
let
stage
;
beforeEach
(()
=>
{
stage
=
{
...
stages
[
0
],
id
:
0
,
dropdownPath
:
stages
[
0
].
dropdown_path
,
jobs
:
[...
jobs
],
isLoading
:
false
,
isCollapsed
:
false
,
};
vm
=
new
Component
({
propsData
:
{
stage
},
});
spyOn
(
vm
,
'
$emit
'
);
vm
.
$mount
();
});
afterEach
(()
=>
{
vm
.
$destroy
();
});
it
(
'
emits fetch event when mounted
'
,
()
=>
{
expect
(
vm
.
$emit
).
toHaveBeenCalledWith
(
'
fetch
'
,
vm
.
stage
);
});
it
(
'
renders stages details
'
,
()
=>
{
expect
(
vm
.
$el
.
textContent
).
toContain
(
vm
.
stage
.
name
);
});
it
(
'
renders CI icon
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.ic-status_failed
'
)).
not
.
toBe
(
null
);
});
describe
(
'
collapsed
'
,
()
=>
{
it
(
'
emits event when clicking header
'
,
done
=>
{
vm
.
$el
.
querySelector
(
'
.card-header
'
).
click
();
vm
.
$nextTick
(()
=>
{
expect
(
vm
.
$emit
).
toHaveBeenCalledWith
(
'
toggleCollapsed
'
,
vm
.
stage
.
id
);
done
();
});
});
it
(
'
toggles collapse status when collapsed
'
,
done
=>
{
vm
.
stage
.
isCollapsed
=
true
;
vm
.
$nextTick
(()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.card-body
'
).
style
.
display
).
toBe
(
'
none
'
);
done
();
});
});
it
(
'
sets border bottom class when collapsed
'
,
done
=>
{
vm
.
stage
.
isCollapsed
=
true
;
vm
.
$nextTick
(()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.card-header
'
).
classList
).
toContain
(
'
border-bottom-0
'
);
done
();
});
});
});
it
(
'
renders jobs count
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.badge
'
).
textContent
).
toContain
(
'
4
'
);
});
it
(
'
renders loading icon when no jobs and isLoading is true
'
,
done
=>
{
vm
.
stage
.
isLoading
=
true
;
vm
.
stage
.
jobs
=
[];
vm
.
$nextTick
(()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
.loading-container
'
)).
not
.
toBe
(
null
);
done
();
});
});
it
(
'
renders list of jobs
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelectorAll
(
'
.ide-job-item
'
).
length
).
toBe
(
4
);
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment