Commit 1efae6b6 authored by alinamihaila's avatar alinamihaila

Add skip_before_action in controller

parent 8355359d
...@@ -10,9 +10,8 @@ RSpec.describe RedisTracking do ...@@ -10,9 +10,8 @@ RSpec.describe RedisTracking do
controller(ApplicationController) do controller(ApplicationController) do
include RedisTracking include RedisTracking
skip_before_action skip_before_action :authenticate_user!, only: :show
track_redis_hll_event :index, :show, name: 'i_analytics_dev_ops_score', feature: :g_compliance_dashboard_feature
track_redis_hll_event :index, name: 'i_analytics_dev_ops_score', feature: :g_compliance_dashboard_feature
def index def index
render html: 'index' render html: 'index'
...@@ -21,6 +20,10 @@ RSpec.describe RedisTracking do ...@@ -21,6 +20,10 @@ RSpec.describe RedisTracking do
def new def new
render html: 'new' render html: 'new'
end end
def show
render html: 'show'
end
end end
context 'with feature disabled' do context 'with feature disabled' do
...@@ -60,6 +63,22 @@ RSpec.describe RedisTracking do ...@@ -60,6 +63,22 @@ RSpec.describe RedisTracking do
end end
end end
context 'when user is not logged in and there is a visitor_id' do
let(:visitor_id) { SecureRandom.uuid }
before do
routes.draw { get 'show' => 'anonymous#show' }
end
it 'tracks the event' do
cookies[:visitor_id] = { value: visitor_id, expires: 24.months }
expect(Gitlab::UsageDataCounters::HLLRedisCounter).to receive(:track_event)
get :show
end
end
context 'when user is not logged in and there is no visitor_id' do context 'when user is not logged in and there is no visitor_id' do
it 'does not tracks the event' do it 'does not tracks the event' do
expect(Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event) expect(Gitlab::UsageDataCounters::HLLRedisCounter).not_to receive(:track_event)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment