Add comment to describe guard clause

1f0ac78e · mo khan · Lin Jen-Shin · 75602aba · 1f0ac78e
Commit 1f0ac78e authored Oct 17, 2019 by mo khan Committed by Lin Jen-Shin Oct 18, 2019
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

ee/app/services/security/sync_reports_to_approval_rules_service.rb ...rvices/security/sync_reports_to_approval_rules_service.rb +2 -0

No files found.
--- a/ee/app/services/security/sync_reports_to_approval_rules_service.rb
+++ b/ee/app/services/security/sync_reports_to_approval_rules_service.rb
@@ -38,6 +38,8 @@ module Security

    def sync_vulnerability_rules
      reports = pipeline.security_reports
+      # If we have some reports, then we want to sync them early;
+      # If we don't have reports, then we should wait until pipeline stops.
      return if reports.empty? && !pipeline.complete?
      return if reports.violates_default_policy?