Merge branch 'allow_pipeline_environments_relation' into 'master'

Allow Pipeline.environments for cross-db query

See merge request gitlab-org/gitlab!72568

app/models/ci/pipeline.rb

@@ -71,7 +71,7 @@ module Ci
     has_many :trigger_requests, dependent: :destroy, foreign_key: :commit_id # rubocop:disable Cop/ActiveRecordDependent
     has_many :variables, class_name: 'Ci::PipelineVariable'
     has_many :deployments, through: :builds
-    has_many :environments, -> { distinct }, through: :deployments
+    has_many :environments, -> { distinct.allow_cross_joins_across_databases(url: 'https://gitlab.com/gitlab-org/gitlab/-/issues/338658') }, through: :deployments
     has_many :latest_builds, -> { latest.with_project_and_metadata }, foreign_key: :commit_id, inverse_of: :pipeline, class_name: 'Ci::Build'
     has_many :downloadable_artifacts, -> do
       not_expired.or(where_exists(::Ci::Pipeline.artifacts_locked.where('ci_pipelines.id = ci_builds.commit_id'))).downloadable.with_job

spec/support/database/cross-join-allowlist.yml

@@ -50,8 +50,6 @@
 - "./spec/requests/api/graphql/packages/pypi_spec.rb"
 - "./spec/requests/api/graphql/project/packages_spec.rb"
 - "./spec/requests/api/package_files_spec.rb"
-- "./spec/services/environments/stop_service_spec.rb"
-- "./spec/services/merge_requests/post_merge_service_spec.rb"
 - "./spec/services/packages/conan/create_package_file_service_spec.rb"
 - "./spec/services/packages/create_package_file_service_spec.rb"
 - "./spec/services/packages/generic/create_package_file_service_spec.rb"