Refactor license compliance query into constants

* Swap out hard coded strings for constsnta

ee/app/assets/javascripts/license_compliance/store/modules/list/actions.js

@@ -3,7 +3,7 @@ import axios from '~/lib/utils/axios_utils';
 import createFlash from '~/flash';
 import { __ } from '~/locale';
 
-import { FETCH_ERROR_MESSAGE } from './constants';
+import { FETCH_ERROR_MESSAGE, SORT_BY, SORT_ORDER } from './constants';
 import * as types from './mutation_types';
 
 export const setLicensesEndpoint = ({ commit }, endpoint) =>
@@ -21,8 +21,8 @@ export const fetchLicenses = ({ state, dispatch }, params = {}) => {
       params: {
         per_page: 10,
         page: state.pageInfo.page || 1,
-        sort_by: 'classification',
-        sort_direction: 'desc',
+        sort_by: SORT_BY.CLASSIFICATION,
+        sort_direction: SORT_ORDER.DESC,
         ...params,
       },
     })

ee/app/assets/javascripts/license_compliance/store/modules/list/constants.js

@@ -11,3 +11,11 @@ export const REPORT_STATUS = {
 export const FETCH_ERROR_MESSAGE = s__(
   'Licenses|Error fetching the license list. Please check your network connection and try again.',
 );
+
+export const SORT_BY = {
+  CLASSIFICATION: 'classification',
+};
+
+export const SORT_ORDER = {
+  DESC: 'desc',
+};

ee/spec/frontend/license_compliance/store/modules/list/actions_spec.js

@@ -6,7 +6,11 @@ import * as actions from 'ee/license_compliance/store/modules/list/actions';
 import * as types from 'ee/license_compliance/store/modules/list/mutation_types';
 import getInitialState from 'ee/license_compliance/store/modules/list/state';
 
-import { FETCH_ERROR_MESSAGE } from 'ee/license_compliance/store/modules/list/constants';
+import {
+  FETCH_ERROR_MESSAGE,
+  SORT_BY,
+  SORT_ORDER,
+} from 'ee/license_compliance/store/modules/list/constants';
 import createFlash from '~/flash';
 
 import mockLicensesResponse from './data/mock_licenses.json';
@@ -141,8 +145,8 @@ describe('Licenses actions', () => {
           const paramsDefault = {
             page: state.pageInfo.page,
             per_page: 10,
-            sort_by: 'classification',
-            sort_direction: 'desc',
+            sort_by: SORT_BY.CLASSIFICATION,
+            sort_direction: SORT_ORDER.DESC,
           };
 
           mock
@@ -176,8 +180,8 @@ describe('Licenses actions', () => {
         const paramsSent = {
           ...paramsGiven,
           per_page: 10,
-          sort_by: 'classification',
-          sort_direction: 'desc',
+          sort_by: SORT_BY.CLASSIFICATION,
+          sort_direction: SORT_ORDER.DESC,
         };
 
         beforeEach(() => {