Fix static analysis offenses

Signed-off-by: Rémy Coutable <remy@rymai.me>

app/helpers/tree_helper.rb

@@ -139,11 +139,11 @@ module TreeHelper
         end
       end
     else
-      _lock_link(current_user: current_user, project: project, html_options: {})
+      _lock_link(current_user, project, html_options: html_options)
     end
   end
 
-  def _lock_link(current_user: current_user, project: project, html_options: {})
+  def _lock_link(user, project, html_options: {})
     if can?(current_user, :push_code, project)
       html_options[:data] = { state: :lock }
       enabled_lock_link("Lock", '', html_options)

app/services/ci/create_pipeline_service.rb

@@ -50,6 +50,12 @@ module Ci
         return error('No builds for this pipeline.')
       end
 
+      _create_pipeline
+    end
+
+    private
+
+    def _create_pipeline
       Ci::Pipeline.transaction do
         update_merge_requests_head_pipeline if pipeline.save
 
@@ -63,8 +69,6 @@ module Ci
       pipeline.tap(&:process!)
     end
 
-    private
-
     def skip_ci?
       return false unless pipeline.git_commit_message
       pipeline.git_commit_message =~ /\[(ci[ _-]skip|skip[ _-]ci)\]/i

lib/gitlab/etag_caching/router.rb

@@ -40,7 +40,7 @@ module Gitlab
         Gitlab::EtagCaching::Router::Route.new(
           %r(^(?!.*(#{RESERVED_WORDS})).*/pipelines/\d+\.json\z),
           'project_pipeline'
-        ),
+        )
       ].freeze
 
       def self.match(env)

lib/gitlab/gitaly_client/commit.rb

@@ -34,7 +34,7 @@ module Gitlab
             left_commit_id: parent_id,
             right_commit_id: commit.id,
             ignore_whitespace_change: options.fetch(:ignore_whitespace_change, false),
-            paths: options.fetch(:paths, []),
+            paths: options.fetch(:paths, [])
           )
 
           Gitlab::Git::DiffCollection.new(stub.commit_diff(request), options)

scripts/trigger-build

@@ -8,7 +8,7 @@ params = {
   "ref" => ENV["OMNIBUS_BRANCH"] || "master",
   "token" => ENV["BUILD_TRIGGER_TOKEN"],
   "variables[GITLAB_VERSION]" => ENV["CI_COMMIT_SHA"],
-  "variables[ALTERNATIVE_SOURCES]" => true,
+  "variables[ALTERNATIVE_SOURCES]" => true
 }
 
 Dir.glob("*_VERSION").each do |version_file|