unmemoize read_ability

since it's only called once now in make_recipient

unmemoize read_ability
since it's only called once now in make_recipient
246951bb · http://jneen.net/ · 934305ff · 246951bb
Commit 246951bb authored Aug 01, 2017 by http://jneen.net/
Show whitespace changes
Inline Side-by-side

Showing with 9 additions and 8 deletions

app/services/notification_recipient_service.rb app/services/notification_recipient_service.rb +9 -8

No files found.
--- a/app/services/notification_recipient_service.rb
+++ b/app/services/notification_recipient_service.rb
@@ -87,7 +87,6 @@ module NotificationRecipientService
      end

      def read_ability
-        @read_ability ||=
        case target
        when Issuable
          :"read_#{target.to_ability_name}"
@@ -308,7 +307,9 @@ module NotificationRecipientService
      end

      def read_ability
-        @read_ability ||= :"read_#{target.class.model_name.name.underscore}"
+        return nil if target.nil?
+
+        :"read_#{target.class.model_name.name.underscore}"
      end

      def build!