Commit 2556532b authored by Mike Jang's avatar Mike Jang

Merge branch 'patch-165' into 'master'

Update saml troubleshooting to reflect new behavior in rails 5

See merge request gitlab-org/gitlab!35568
parents d43602d8 39a0163f
...@@ -580,13 +580,14 @@ Make sure the IdP provides a claim containing the user's email address, using cl ...@@ -580,13 +580,14 @@ Make sure the IdP provides a claim containing the user's email address, using cl
If after signing in into your SAML server you are redirected back to the sign in page and If after signing in into your SAML server you are redirected back to the sign in page and
no error is displayed, check your `production.log` file. It will most likely contain the no error is displayed, check your `production.log` file. It will most likely contain the
message `Can't verify CSRF token authenticity`. This means that there is an error during message `Can't verify CSRF token authenticity`. This means that there is an error during
the SAML request, but this error never reaches GitLab due to the CSRF check. the SAML request, but in GitLab 11.7 and earlier this error never reaches GitLab due to
the CSRF check.
To bypass this you can add `skip_before_action :verify_authenticity_token` to the To bypass this you can add `skip_before_action :verify_authenticity_token` to the
`omniauth_callbacks_controller.rb` file immediately after the `class` line and `omniauth_callbacks_controller.rb` file immediately after the `class` line and
comment out the `protect_from_forgery` line using a `#` then restart Unicorn. This comment out the `protect_from_forgery` line using a `#`. Restart Unicorn for this
will allow the error to hit GitLab, where it can then be seen in the usual logs, change to take effect. This will allow the error to hit GitLab, where it can then
or as a flash message on the login screen. be seen in the usual logs, or as a flash message on the login screen.
That file is located in `/opt/gitlab/embedded/service/gitlab-rails/app/controllers` That file is located in `/opt/gitlab/embedded/service/gitlab-rails/app/controllers`
for Omnibus installations and by default in `/home/git/gitlab/app/controllers` for for Omnibus installations and by default in `/home/git/gitlab/app/controllers` for
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment