Commit 26b9c50c authored by Scott Hampton's avatar Scott Hampton

Switch feature flag to default to :yaml

Feature flag should default to whatever the yaml
config says it should default to. We can do this by
changing `true` to `:yaml` in the push to frontend.

Also added a couple comments to clarify why we
are handling async calls the way we are in the jest
test.
parent f89cb044
...@@ -8,7 +8,7 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl ...@@ -8,7 +8,7 @@ class Groups::Analytics::RepositoryAnalyticsController < Groups::Analytics::Appl
before_action -> { check_feature_availability!(:group_repository_analytics) } before_action -> { check_feature_availability!(:group_repository_analytics) }
before_action -> { authorize_view_by_action!(:read_group_repository_analytics) } before_action -> { authorize_view_by_action!(:read_group_repository_analytics) }
before_action only: [:show] do before_action only: [:show] do
push_frontend_feature_flag(:usage_data_i_testing_group_code_coverage_project_click_total, @group, default_enabled: true) push_frontend_feature_flag(:usage_data_i_testing_group_code_coverage_project_click_total, @group, default_enabled: :yaml)
end end
track_redis_hll_event :show, name: 'i_testing_group_code_coverage_visit_total', feature: :usage_data_i_testing_group_code_coverage_visit_total, feature_default_enabled: true track_redis_hll_event :show, name: 'i_testing_group_code_coverage_visit_total', feature: :usage_data_i_testing_group_code_coverage_visit_total, feature_default_enabled: true
......
...@@ -262,6 +262,9 @@ describe('Test coverage table component', () => { ...@@ -262,6 +262,9 @@ describe('Test coverage table component', () => {
mountFn: mount, mountFn: mount,
glFeatures: { usageDataITestingGroupCodeCoverageProjectClickTotal: true }, glFeatures: { usageDataITestingGroupCodeCoverageProjectClickTotal: true },
}); });
// We have to wait for apollo to make the mock query and fill the table before
// we can click on the project link inside the table. Neither `runOnlyPendingTimers`
// nor `waitForPromises` work on their own to accomplish this.
jest.runOnlyPendingTimers(); jest.runOnlyPendingTimers();
await waitForPromises(); await waitForPromises();
findProjectNameById(id).trigger('click'); findProjectNameById(id).trigger('click');
...@@ -304,6 +307,9 @@ describe('Test coverage table component', () => { ...@@ -304,6 +307,9 @@ describe('Test coverage table component', () => {
mountFn: mount, mountFn: mount,
glFeatures: { usageDataITestingGroupCodeCoverageProjectClickTotal: false }, glFeatures: { usageDataITestingGroupCodeCoverageProjectClickTotal: false },
}); });
// We have to wait for apollo to make the mock query and fill the table before
// we can click on the project link inside the table. Neither `runOnlyPendingTimers`
// nor `waitForPromises` work on their own to accomplish this.
jest.runOnlyPendingTimers(); jest.runOnlyPendingTimers();
await waitForPromises(); await waitForPromises();
findProjectNameById(id).trigger('click'); findProjectNameById(id).trigger('click');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment