Merge branch 'rspec-empty-line-after-letitbe-ee-spec-services-ee' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/services/ee

See merge request gitlab-org/gitlab!58351

.rubocop_manual_todo.yml

@@ -623,20 +623,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/services/dast_scanner_profiles/update_service_spec.rb
     - ee/spec/services/dast_site_profiles/destroy_service_spec.rb
     - ee/spec/services/dora/aggregate_metrics_service_spec.rb
-    - ee/spec/services/ee/audit_events/protected_branch_audit_event_service_spec.rb
-    - ee/spec/services/ee/ci/change_variable_service_spec.rb
-    - ee/spec/services/ee/ci/change_variables_service_spec.rb
-    - ee/spec/services/ee/design_management/delete_designs_service_spec.rb
-    - ee/spec/services/ee/git/branch_push_service_spec.rb
-    - ee/spec/services/ee/issuable/bulk_update_service_spec.rb
-    - ee/spec/services/ee/issues/create_service_spec.rb
-    - ee/spec/services/ee/issues/update_service_spec.rb
-    - ee/spec/services/ee/labels/create_service_spec.rb
-    - ee/spec/services/ee/merge_requests/base_service_spec.rb
-    - ee/spec/services/ee/notes/create_service_spec.rb
-    - ee/spec/services/ee/notification_service_spec.rb
-    - ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb
-    - ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb
     - ee/spec/services/external_approval_rules/create_service_spec.rb
     - ee/spec/services/external_approval_rules/destroy_service_spec.rb
     - ee/spec/services/external_approval_rules/update_service_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-ee.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/services/ee
+merge_request: 58351
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/services/ee/audit_events/protected_branch_audit_event_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe EE::AuditEvents::ProtectedBranchAuditEventService, :request_store
   let_it_be(:author) { create(:user, :with_sign_ins) }
   let_it_be(:entity) { create(:project, creator: author) }
   let_it_be(:protected_branch) { create(:protected_branch, :no_one_can_push, project: entity) }
+
   let(:logger) { instance_spy(Gitlab::AuditJsonLogger) }
   let(:ip_address) { '192.168.15.18' }
 

ee/spec/services/ee/ci/change_variable_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Ci::ChangeVariableService do
   subject(:execute) { service.execute }
 
   let_it_be(:user) { create(:user) }
+
   let(:group) { create(:group) }
   let(:audit_service_spy) { class_spy(::Ci::AuditVariableChangeService, new: spy) }
 

ee/spec/services/ee/ci/change_variables_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Ci::ChangeVariablesService do
   subject(:execute) { service.execute }
 
   let_it_be(:user) { create(:user) }
+
   let(:group) { create(:group) }
   let(:audit_service_spy) { class_spy(Ci::AuditVariableChangeService, new: spy) }
 

ee/spec/services/ee/design_management/delete_designs_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe DesignManagement::DeleteDesignsService do
   let_it_be(:issue) { create(:issue, project: project) }
   let_it_be(:user) { create(:user) }
   let_it_be(:design_repository) { ::Gitlab::GlRepository::DESIGN.repository_resolver.call(project)}
+
   let!(:design) { create(:design, :with_lfs_file, issue: issue) }
 
   subject { described_class.new(project, user, issue: issue, designs: [design]) }

ee/spec/services/ee/git/branch_push_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Git::BranchPushService do
   include RepoHelpers
 
   let_it_be(:user) { create(:user) }
+
   let(:blankrev)   { Gitlab::Git::BLANK_SHA }
   let(:oldrev)     { sample_commit.parent_id }
   let(:newrev)     { sample_commit.id }

ee/spec/services/ee/issuable/bulk_update_service_spec.rb

@@ -31,6 +31,7 @@ RSpec.describe Issuable::BulkUpdateService do
   context 'with issues' do
     let_it_be(:type) { 'issue' }
     let_it_be(:parent) { group }
+
     let(:issue1) { create(:issue, project: project1, health_status: :at_risk) }
     let(:issue2) { create(:issue, project: project2, health_status: :at_risk) }
     let(:issuables) { [issue1, issue2] }

ee/spec/services/ee/issues/create_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Issues::CreateService do
   let_it_be(:group) { create(:group) }
+
   let(:project) { create(:project, group: group) }
   let(:user) { create(:user) }
   let(:params) { { title: 'Awesome issue', description: 'please fix', weight: 9 } }

ee/spec/services/ee/issues/update_service_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Issues::UpdateService do
   let_it_be(:group) { create(:group) }
+
   let(:project) { create(:project, group: group) }
   let(:issue) { create(:issue, project: project) }
   let(:user) { issue.author }
@@ -19,6 +20,7 @@ RSpec.describe Issues::UpdateService do
 
     context 'refresh epic dates' do
       let_it_be(:epic) { create(:epic) }
+
       let(:issue) { create(:issue, epic: epic, project: project) }
 
       context 'updating milestone' do

ee/spec/services/ee/labels/create_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe Labels::CreateService do
   describe '#execute' do
     let_it_be(:project) { create(:project) }
     let_it_be(:namespace) { create(:group) }
+
     let(:params) do
       {
         title: title,

ee/spec/services/ee/merge_requests/base_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe MergeRequests::BaseService do
   include ProjectForksHelper
 
   let_it_be(:project) { create(:project, :repository) }
+
   let(:title) { 'Awesome merge_request' }
   let(:params) do
     {

ee/spec/services/ee/notes/create_service_spec.rb

@@ -63,6 +63,7 @@ RSpec.describe Notes::CreateService do
 
     context 'for epics' do
       let_it_be(:epic) { create(:epic) }
+
       let(:opts) { { noteable_type: 'Epic', noteable_id: epic.id, note: "hello" } }
 
       it 'tracks epic note creation' do

ee/spec/services/ee/notification_service_spec.rb

@@ -231,6 +231,7 @@ RSpec.describe EE::NotificationService, :mailer do
   describe 'mirror was disabled' do
     let_it_be(:user) { create(:user) }
     let_it_be(:project) { create(:project) }
+
     let(:deleted_username) { 'deleted_user_name' }
 
     context 'when the project has invited members' do

ee/spec/services/ee/resource_events/merge_into_notes_service_spec.rb

@@ -26,6 +26,7 @@ RSpec.describe ResourceEvents::MergeIntoNotesService do
   let_it_be(:scoped_label_group2_1) { create(:label, project: project, title: 'key2::value') }
   let_it_be(:scoped_label_group2_2) { create(:label, project: project, title: 'key2::value2') }
   let_it_be(:scoped_label_group3_1) { create(:label, project: project, title: 'key3::value') }
+
   let(:time) { Time.current }
 
   describe '#execute' do

ee/spec/services/ee/todos/destroy/entity_leave_service_spec.rb

@@ -9,6 +9,7 @@ RSpec.describe Todos::Destroy::EntityLeaveService do
 
   let_it_be(:epic1) { create(:epic, confidential: true, group: subgroup) }
   let_it_be(:epic2) { create(:epic, group: subgroup) }
+
   let!(:todo1) { create(:todo, target: epic1, user: user, group: subgroup) }
   let!(:todo2) { create(:todo, target: epic2, user: user, group: subgroup) }