Commit 2b541e6c authored by Eric Eastwood's avatar Eric Eastwood Committed by Sean McGivern

Update icons to be accessible

Address @filipa review

 - Accessible icons
 - nits
parent c3987518
...@@ -44,12 +44,10 @@ export default { ...@@ -44,12 +44,10 @@ export default {
template: ` template: `
<div> <div>
<div class="checkbox"> <div class="checkbox">
<label for="project_service_desk_enabled"> <label for="service-desk-enabled-checkbox">
<input <input
type="checkbox" type="checkbox"
value="1" id="service-desk-enabled-checkbox"
name="project[service_desk_enabled]"
id="project_service_desk_enabled"
:checked="isActivated" :checked="isActivated"
@change="onCheckboxToggle($event)"> @change="onCheckboxToggle($event)">
<span class="descr"> <span class="descr">
...@@ -67,7 +65,7 @@ export default { ...@@ -67,7 +65,7 @@ export default {
</div> </div>
<div class="panel-body"> <div class="panel-body">
<template v-if="fetchError"> <template v-if="fetchError">
<i class="fa fa-exclamation-circle" /> <i class="fa fa-exclamation-circle" aria-hidden="true" />
An error occurred while fetching the incoming email An error occurred while fetching the incoming email
</template> </template>
<template v-else-if="incomingEmail"> <template v-else-if="incomingEmail">
...@@ -78,11 +76,14 @@ export default { ...@@ -78,11 +76,14 @@ export default {
class="btn btn-clipboard btn-transparent" class="btn btn-clipboard btn-transparent"
title="Copy incoming email address to clipboard" title="Copy incoming email address to clipboard"
@click="copyIncomingEmail($event)"> @click="copyIncomingEmail($event)">
<i class="fa fa-clipboard" /> <i class="fa fa-clipboard" aria-hidden="true" />
</button> </button>
</template> </template>
<template v-else> <template v-else>
<i class="fa fa-spinner fa-spin" /> <i class="fa fa-spinner fa-spin" aria-hidden="true" />
<span class="sr-only">
Fetching incoming email
</span>
</template> </template>
</div> </div>
</div> </div>
......
/* eslint-disable no-param-reassign */
import Vue from 'vue'; import Vue from 'vue';
import vueResource from 'vue-resource'; import vueResource from 'vue-resource';
import '../../../vue_shared/vue_resource_interceptor'; import '../../../vue_shared/vue_resource_interceptor';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment