Commit 2f3b2820 authored by Marius Bobin's avatar Marius Bobin

Create trace artifact and update metadata inside a database transaction

parent bbf08ffe
...@@ -15,10 +15,14 @@ module Ci ...@@ -15,10 +15,14 @@ module Ci
def execute!(stream) def execute!(stream)
clone_file!(stream, JobArtifactUploader.workhorse_upload_path) do |clone_path| clone_file!(stream, JobArtifactUploader.workhorse_upload_path) do |clone_path|
md5_checksum = self.class.md5_hexdigest(clone_path) md5_checksum = self.class.md5_hexdigest(clone_path)
trace_artifact = create_build_trace!(job, clone_path) sha256_checksum = self.class.sha256_hexdigest(clone_path)
job.transaction do
trace_artifact = create_build_trace!(clone_path, sha256_checksum)
trace_metadata.track_archival!(trace_artifact.id, md5_checksum) trace_metadata.track_archival!(trace_artifact.id, md5_checksum)
end end
end end
end
private private
...@@ -34,7 +38,7 @@ module Ci ...@@ -34,7 +38,7 @@ module Ci
end end
end end
def create_build_trace!(job, path) def create_build_trace!(path, file_sha256)
File.open(path) do |stream| File.open(path) do |stream|
# TODO: Set `file_format: :raw` after we've cleaned up legacy traces migration # TODO: Set `file_format: :raw` after we've cleaned up legacy traces migration
# https://gitlab.com/gitlab-org/gitlab-foss/merge_requests/20307 # https://gitlab.com/gitlab-org/gitlab-foss/merge_requests/20307
...@@ -42,7 +46,7 @@ module Ci ...@@ -42,7 +46,7 @@ module Ci
project: job.project, project: job.project,
file_type: :trace, file_type: :trace,
file: stream, file: stream,
file_sha256: self.class.sha256_hexdigest(path)) file_sha256: file_sha256)
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment