Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
31756894
Commit
31756894
authored
Oct 15, 2019
by
Arturo Herrero
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Docs: Update Gotchas page with comment clarifications
parent
b70abe63
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
0 deletions
+2
-0
doc/development/gotchas.md
doc/development/gotchas.md
+2
-0
No files found.
doc/development/gotchas.md
View file @
31756894
...
@@ -114,6 +114,7 @@ Instead of writing:
...
@@ -114,6 +114,7 @@ Instead of writing:
# Don't do this:
# Don't do this:
expect_any_instance_of
(
Project
).
to
receive
(
:add_import_job
)
expect_any_instance_of
(
Project
).
to
receive
(
:add_import_job
)
# Don't do this:
allow_any_instance_of
(
Project
).
to
receive
(
:add_import_job
)
allow_any_instance_of
(
Project
).
to
receive
(
:add_import_job
)
```
```
...
@@ -125,6 +126,7 @@ expect_next_instance_of(Project) do |project|
...
@@ -125,6 +126,7 @@ expect_next_instance_of(Project) do |project|
expect
(
project
).
to
receive
(
:add_import_job
)
expect
(
project
).
to
receive
(
:add_import_job
)
end
end
# Do this:
allow_next_instance_of
(
Project
)
do
|
project
|
allow_next_instance_of
(
Project
)
do
|
project
|
allow
(
project
).
to
receive
(
:add_import_job
)
allow
(
project
).
to
receive
(
:add_import_job
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment