Merge branch '31343-remove-unneccessary-freeze' into 'master'

Remove unnecessary use of freeze

See merge request gitlab-org/gitlab!50963

app/finders/deployments_finder.rb

@@ -4,10 +4,10 @@ class DeploymentsFinder
   attr_reader :project, :params
 
   ALLOWED_SORT_VALUES = %w[id iid created_at updated_at ref].freeze
-  DEFAULT_SORT_VALUE = 'id'.freeze
+  DEFAULT_SORT_VALUE = 'id'
 
   ALLOWED_SORT_DIRECTIONS = %w[asc desc].freeze
-  DEFAULT_SORT_DIRECTION = 'asc'.freeze
+  DEFAULT_SORT_DIRECTION = 'asc'
 
   def initialize(project, params = {})
     @project = project

app/models/authentication_event.rb

@@ -3,10 +3,10 @@
 class AuthenticationEvent < ApplicationRecord
   include UsageStatistics
 
-  TWO_FACTOR = 'two-factor'.freeze
-  TWO_FACTOR_U2F = 'two-factor-via-u2f-device'.freeze
-  TWO_FACTOR_WEBAUTHN = 'two-factor-via-webauthn-device'.freeze
-  STANDARD = 'standard'.freeze
+  TWO_FACTOR = 'two-factor'
+  TWO_FACTOR_U2F = 'two-factor-via-u2f-device'
+  TWO_FACTOR_WEBAUTHN = 'two-factor-via-webauthn-device'
+  STANDARD = 'standard'
   STATIC_PROVIDERS = [TWO_FACTOR, TWO_FACTOR_U2F, TWO_FACTOR_WEBAUTHN, STANDARD].freeze
 
   belongs_to :user, optional: true

app/models/ci/build_runner_session.rb

@@ -7,8 +7,8 @@ module Ci
     extend Gitlab::Ci::Model
 
     TERMINAL_SUBPROTOCOL = 'terminal.gitlab.com'
-    DEFAULT_SERVICE_NAME = 'build'.freeze
-    DEFAULT_PORT_NAME = 'default_port'.freeze
+    DEFAULT_SERVICE_NAME = 'build'
+    DEFAULT_PORT_NAME = 'default_port'
 
     self.table_name = 'ci_builds_runner_session'
 

app/models/namespace/root_storage_statistics.rb

 # frozen_string_literal: true
 
 class Namespace::RootStorageStatistics < ApplicationRecord
-  SNIPPETS_SIZE_STAT_NAME = 'snippets_size'.freeze
+  SNIPPETS_SIZE_STAT_NAME = 'snippets_size'
   STATISTICS_ATTRIBUTES = %W(
     storage_size
     repository_size

app/models/packages/conan/file_metadatum.rb

@@ -3,8 +3,8 @@
 class Packages::Conan::FileMetadatum < ApplicationRecord
   belongs_to :package_file, inverse_of: :conan_file_metadatum
 
-  DEFAULT_PACKAGE_REVISION = '0'.freeze
-  DEFAULT_RECIPE_REVISION = '0'.freeze
+  DEFAULT_PACKAGE_REVISION = '0'
+  DEFAULT_RECIPE_REVISION = '0'
 
   validates :package_file, presence: true
 

app/models/packages/dependency.rb

@@ -6,7 +6,7 @@ class Packages::Dependency < ApplicationRecord
 
   validates :name, uniqueness: { scope: :version_pattern }
 
-  NAME_VERSION_PATTERN_TUPLE_MATCHING = '(name, version_pattern) = (?, ?)'.freeze
+  NAME_VERSION_PATTERN_TUPLE_MATCHING = '(name, version_pattern) = (?, ?)'
   MAX_STRING_LENGTH = 255.freeze
   MAX_CHUNKED_QUERIES_COUNT = 10.freeze
 

app/models/plan.rb

 # frozen_string_literal: true
 
 class Plan < ApplicationRecord
-  DEFAULT = 'default'.freeze
+  DEFAULT = 'default'
 
   has_one :limits, class_name: 'PlanLimits'
 

app/models/project_feature_usage.rb

@@ -3,8 +3,8 @@
 class ProjectFeatureUsage < ApplicationRecord
   self.primary_key = :project_id
 
-  JIRA_DVCS_CLOUD_FIELD = 'jira_dvcs_cloud_last_sync_at'.freeze
-  JIRA_DVCS_SERVER_FIELD = 'jira_dvcs_server_last_sync_at'.freeze
+  JIRA_DVCS_CLOUD_FIELD = 'jira_dvcs_cloud_last_sync_at'
+  JIRA_DVCS_SERVER_FIELD = 'jira_dvcs_server_last_sync_at'
 
   belongs_to :project
   validates :project, presence: true

app/models/project_services/datadog_service.rb

 # frozen_string_literal: true
 
 class DatadogService < Service
-  DEFAULT_SITE = 'datadoghq.com'.freeze
-  URL_TEMPLATE = 'https://webhooks-http-intake.logs.%{datadog_site}/v1/input/'.freeze
-  URL_TEMPLATE_API_KEYS = 'https://app.%{datadog_site}/account/settings#api'.freeze
-  URL_API_KEYS_DOCS = "https://docs.#{DEFAULT_SITE}/account_management/api-app-keys/".freeze
+  DEFAULT_SITE = 'datadoghq.com'
+  URL_TEMPLATE = 'https://webhooks-http-intake.logs.%{datadog_site}/v1/input/'
+  URL_TEMPLATE_API_KEYS = 'https://app.%{datadog_site}/account/settings#api'
+  URL_API_KEYS_DOCS = "https://docs.#{DEFAULT_SITE}/account_management/api-app-keys/"
 
   SUPPORTED_EVENTS = %w[
     pipeline job

app/models/user.rb

@@ -31,7 +31,7 @@ class User < ApplicationRecord
 
   INSTANCE_ACCESS_REQUEST_APPROVERS_TO_BE_NOTIFIED_LIMIT = 10
 
-  BLOCKED_PENDING_APPROVAL_STATE = 'blocked_pending_approval'.freeze
+  BLOCKED_PENDING_APPROVAL_STATE = 'blocked_pending_approval'
 
   add_authentication_token_field :incoming_email_token, token_generator: -> { SecureRandom.hex.to_i(16).to_s(36) }
   add_authentication_token_field :feed_token

app/presenters/packages/nuget/service_index_presenter.rb

@@ -19,7 +19,7 @@ module Packages
         metadata: 'Get package metadata.'
       }.freeze
 
-      VERSION = '3.0.0'.freeze
+      VERSION = '3.0.0'
 
       PROJECT_LEVEL_SERVICES = %i[download publish].freeze
       GROUP_LEVEL_SERVICES = %i[search metadata].freeze

app/services/ci/create_web_ide_terminal_service.rb

@@ -6,7 +6,7 @@ module Ci
 
     TerminalCreationError = Class.new(StandardError)
 
-    TERMINAL_NAME = 'terminal'.freeze
+    TERMINAL_NAME = 'terminal'
 
     attr_reader :terminal
 

app/services/ci/register_job_service.rb

@@ -8,8 +8,8 @@ module Ci
 
     JOB_QUEUE_DURATION_SECONDS_BUCKETS = [1, 3, 10, 30, 60, 300, 900, 1800, 3600].freeze
     JOBS_RUNNING_FOR_PROJECT_MAX_BUCKET = 5.freeze
-    METRICS_SHARD_TAG_PREFIX = 'metrics_shard::'.freeze
-    DEFAULT_METRICS_SHARD = 'default'.freeze
+    METRICS_SHARD_TAG_PREFIX = 'metrics_shard::'
+    DEFAULT_METRICS_SHARD = 'default'
 
     Result = Struct.new(:build, :build_json, :valid?)
 

app/services/ide/base_config_service.rb

@@ -4,7 +4,7 @@ module Ide
   class BaseConfigService < ::BaseService
     ValidationError = Class.new(StandardError)
 
-    WEBIDE_CONFIG_FILE = '.gitlab/.gitlab-webide.yml'.freeze
+    WEBIDE_CONFIG_FILE = '.gitlab/.gitlab-webide.yml'
 
     attr_reader :config, :config_content
 

app/services/packages/maven/find_or_create_package_service.rb

@@ -2,8 +2,8 @@
 module Packages
   module Maven
     class FindOrCreatePackageService < BaseService
-      MAVEN_METADATA_FILE = 'maven-metadata.xml'.freeze
-      SNAPSHOT_TERM = '-SNAPSHOT'.freeze
+      MAVEN_METADATA_FILE = 'maven-metadata.xml'
+      SNAPSHOT_TERM = '-SNAPSHOT'
 
       def execute
         package =

app/services/serverless/associate_domain_service.rb

@@ -2,7 +2,7 @@
 
 module Serverless
   class AssociateDomainService
-    PLACEHOLDER_HOSTNAME = 'example.com'.freeze
+    PLACEHOLDER_HOSTNAME = 'example.com'
 
     def initialize(knative, pages_domain_id:, creator:)
       @knative = knative

app/validators/feature_flag_strategies_validator.rb

 # frozen_string_literal: true
 
 class FeatureFlagStrategiesValidator < ActiveModel::EachValidator
-  STRATEGY_DEFAULT = 'default'.freeze
-  STRATEGY_GRADUALROLLOUTUSERID = 'gradualRolloutUserId'.freeze
-  STRATEGY_USERWITHID = 'userWithId'.freeze
+  STRATEGY_DEFAULT = 'default'
+  STRATEGY_GRADUALROLLOUTUSERID = 'gradualRolloutUserId'
+  STRATEGY_USERWITHID = 'userWithId'
   # Order key names alphabetically
   STRATEGIES = {
     STRATEGY_DEFAULT => [].freeze,

changelogs/unreleased/31343-remove-unneccessary-freeze.yml

+---
+title: Remove unnecessary use of .freeze
+merge_request: 50963
+author: Adam Davies @adamd92
+type: other

danger/roulette/Dangerfile

@@ -38,8 +38,8 @@ Please consider creating a merge request to
 for them.
 MARKDOWN
 
-OPTIONAL_REVIEW_TEMPLATE = "%{role} review is optional for %{category}".freeze
-NOT_AVAILABLE_TEMPLATE = 'No %{role} available'.freeze
+OPTIONAL_REVIEW_TEMPLATE = '%{role} review is optional for %{category}'
+NOT_AVAILABLE_TEMPLATE = 'No %{role} available'
 
 def note_for_spins_role(spins, role)
   spins.each do |spin|

db/migrate/20190108192941_remove_partial_index_from_ci_builds_artifacts_file.rb

@@ -4,7 +4,7 @@ class RemovePartialIndexFromCiBuildsArtifactsFile < ActiveRecord::Migration[5.0]
   include Gitlab::Database::MigrationHelpers
 
   DOWNTIME = false
-  INDEX_NAME = 'partial_index_ci_builds_on_id_with_legacy_artifacts'.freeze
+  INDEX_NAME = 'partial_index_ci_builds_on_id_with_legacy_artifacts'
 
   disable_ddl_transaction!