Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
33ef4a85
Commit
33ef4a85
authored
Apr 24, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
edf694c8
23e5d9ed
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
1 deletion
+15
-1
app/controllers/projects/settings/ci_cd_controller.rb
app/controllers/projects/settings/ci_cd_controller.rb
+1
-1
changelogs/unreleased/54656-500-error-on-save-of-general-pipeline-settings-timeout.yml
...00-error-on-save-of-general-pipeline-settings-timeout.yml
+5
-0
spec/controllers/projects/settings/ci_cd_controller_spec.rb
spec/controllers/projects/settings/ci_cd_controller_spec.rb
+9
-0
No files found.
app/controllers/projects/settings/ci_cd_controller.rb
View file @
33ef4a85
...
@@ -19,7 +19,7 @@ module Projects
...
@@ -19,7 +19,7 @@ module Projects
redirect_to
project_settings_ci_cd_path
(
@project
)
redirect_to
project_settings_ci_cd_path
(
@project
)
else
else
re
nder
'show'
re
direct_to
project_settings_ci_cd_path
(
@project
),
alert:
result
[
:message
]
end
end
end
end
end
end
...
...
changelogs/unreleased/54656-500-error-on-save-of-general-pipeline-settings-timeout.yml
0 → 100644
View file @
33ef4a85
---
title
:
Fix 500 in general pipeline settings when passing an invalid build timeout.
merge_request
:
27416
author
:
type
:
fixed
spec/controllers/projects/settings/ci_cd_controller_spec.rb
View file @
33ef4a85
...
@@ -191,6 +191,15 @@ describe Projects::Settings::CiCdController do
...
@@ -191,6 +191,15 @@ describe Projects::Settings::CiCdController do
expect
(
project
.
build_timeout
).
to
eq
(
5400
)
expect
(
project
.
build_timeout
).
to
eq
(
5400
)
end
end
end
end
context
'when build_timeout_human_readable is invalid'
do
let
(
:params
)
{
{
build_timeout_human_readable:
'5m'
}
}
it
'set specified timeout'
do
expect
(
subject
).
to
set_flash
[
:alert
]
expect
(
response
).
to
redirect_to
(
namespace_project_settings_ci_cd_path
)
end
end
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment