Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
3554a22b
Commit
3554a22b
authored
Feb 17, 2020
by
Albert Salim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Include resource type in `KubernetesClient#raw_resource_names`
parent
5cd90761
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
lib/quality/kubernetes_client.rb
lib/quality/kubernetes_client.rb
+1
-1
spec/lib/quality/kubernetes_client_spec.rb
spec/lib/quality/kubernetes_client_spec.rb
+1
-1
No files found.
lib/quality/kubernetes_client.rb
View file @
3554a22b
...
...
@@ -63,7 +63,7 @@ module Quality
'get'
,
RESOURCE_LIST
,
%(--namespace "#{namespace}")
,
'-o
custom-columns=NAME:.metadata.
name'
'-o name'
]
run_command
(
command
).
lines
.
map
(
&
:strip
)
end
...
...
spec/lib/quality/kubernetes_client_spec.rb
View file @
3554a22b
...
...
@@ -102,7 +102,7 @@ RSpec.describe Quality::KubernetesClient do
it
'calls kubectl to retrieve the resource names'
do
expect
(
Gitlab
::
Popen
).
to
receive
(
:popen_with_detail
)
.
with
([
"kubectl get
#{
described_class
::
RESOURCE_LIST
}
"
+
%(--namespace "#{namespace}" -o
custom-columns=NAME:.metadata.
name)
])
%(--namespace "#{namespace}" -o name)
])
.
and_return
(
Gitlab
::
Popen
::
Result
.
new
([],
raw_resource_names_str
,
''
,
double
(
success?:
true
)))
expect
(
subject
.
__send__
(
:raw_resource_names
)).
to
eq
(
raw_resource_names
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment