Merge branch '11432-fix-gitlab-subscription-' into 'master'

Fix default value for start date in GitlabSubscription being static

Closes #11432

See merge request gitlab-org/gitlab-ee!12110

ee/app/models/gitlab_subscription.rb

 # frozen_string_literal: true
 
 class GitlabSubscription < ApplicationRecord
-  default_value_for :start_date, Date.today
+  default_value_for(:start_date) { Date.today }
 
   belongs_to :namespace
   belongs_to :hosted_plan, class_name: 'Plan'

ee/spec/models/gitlab_subscription_spec.rb

 require 'spec_helper'
 
 describe GitlabSubscription do
-  around do |example|
-    Timecop.freeze do
-      example.run
-    end
-  end
-
   describe 'default values' do
     it do
+      Timecop.freeze(Date.today + 30) do
         expect(subject.start_date).to eq(Date.today)
       end
     end
+  end
 
   describe 'validations' do
     it { is_expected.to validate_presence_of(:seats) }