Commit 37fc82ac authored by Douwe Maan's avatar Douwe Maan

Resolve conflicts

parent ed2a8ba6
...@@ -39,40 +39,25 @@ class Groups::GroupMembersController < Groups::ApplicationController ...@@ -39,40 +39,25 @@ class Groups::GroupMembersController < Groups::ApplicationController
return render_403 unless can?(current_user, :update_group_member, @group_member) return render_403 unless can?(current_user, :update_group_member, @group_member)
<<<<<<< HEAD old_access_level = @group_member.human_access
old_access_level = @member.human_access
if @member.update_attributes(member_params) if @group_member.update_attributes(member_params)
log_audit_event(@member, action: :update, old_access_level: old_access_level) log_audit_event(@group_member, action: :update, old_access_level: old_access_level)
end end
=======
@group_member.update_attributes(member_params)
>>>>>>> ce/8-2-stable
end end
def destroy def destroy
@group_member = @group.group_members.find(params[:id]) @group_member = @group.group_members.find(params[:id])
<<<<<<< HEAD
if can?(current_user, :destroy_group_member, @group_member) # May fail if last owner.
@group_member.destroy
log_audit_event(@group_member, action: :destroy)
respond_to do |format|
format.html { redirect_to group_group_members_path(@group), notice: 'User was successfully removed from group.' }
format.js { render nothing: true }
end
else
return render_403
=======
return render_403 unless can?(current_user, :destroy_group_member, @group_member) return render_403 unless can?(current_user, :destroy_group_member, @group_member)
@group_member.destroy @group_member.destroy
log_audit_event(@group_member, action: :destroy)
respond_to do |format| respond_to do |format|
format.html { redirect_to group_group_members_path(@group), notice: 'User was successfully removed from group.' } format.html { redirect_to group_group_members_path(@group), notice: 'User was successfully removed from group.' }
format.js { render nothing: true } format.js { render nothing: true }
>>>>>>> ce/8-2-stable
end end
end end
...@@ -95,10 +80,8 @@ class Groups::GroupMembersController < Groups::ApplicationController ...@@ -95,10 +80,8 @@ class Groups::GroupMembersController < Groups::ApplicationController
if can?(current_user, :destroy_group_member, @group_member) if can?(current_user, :destroy_group_member, @group_member)
@group_member.destroy @group_member.destroy
<<<<<<< HEAD
log_audit_event(@group_member, action: :destroy) log_audit_event(@group_member, action: :destroy)
=======
>>>>>>> ce/8-2-stable
redirect_to(dashboard_groups_path, notice: "You left #{group.name} group.") redirect_to(dashboard_groups_path, notice: "You left #{group.name} group.")
else else
......
...@@ -43,18 +43,14 @@ class Projects::ProjectMembersController < Projects::ApplicationController ...@@ -43,18 +43,14 @@ class Projects::ProjectMembersController < Projects::ApplicationController
def update def update
@project_member = @project.project_members.find(params[:id]) @project_member = @project.project_members.find(params[:id])
<<<<<<< HEAD
return render_403 unless can?(current_user, :update_project_member, @project_member)
old_access_level = @project_member.human_access old_access_level = @project_member.human_access
if @project_member.update_attributes(member_params) if @project_member.update_attributes(member_params)
log_audit_event(@project_member, action: :update, old_access_level: old_access_level) log_audit_event(@project_member, action: :update, old_access_level: old_access_level)
end end
=======
return render_403 unless can?(current_user, :update_project_member, @project_member)
@project_member.update_attributes(member_params)
>>>>>>> ce/8-2-stable
end end
def destroy def destroy
...@@ -63,6 +59,7 @@ class Projects::ProjectMembersController < Projects::ApplicationController ...@@ -63,6 +59,7 @@ class Projects::ProjectMembersController < Projects::ApplicationController
return render_403 unless can?(current_user, :destroy_project_member, @project_member) return render_403 unless can?(current_user, :destroy_project_member, @project_member)
@project_member.destroy @project_member.destroy
log_audit_event(@project_member, action: :destroy) log_audit_event(@project_member, action: :destroy)
respond_to do |format| respond_to do |format|
...@@ -90,14 +87,10 @@ class Projects::ProjectMembersController < Projects::ApplicationController ...@@ -90,14 +87,10 @@ class Projects::ProjectMembersController < Projects::ApplicationController
def leave def leave
@project_member = @project.project_members.find_by(user_id: current_user) @project_member = @project.project_members.find_by(user_id: current_user)
<<<<<<< HEAD
@project_member = @project.project_members.find_by(user_id: current_user)
@project_member.destroy
log_audit_event(@project_member, action: :destroy)
=======
if can?(current_user, :destroy_project_member, @project_member) if can?(current_user, :destroy_project_member, @project_member)
@project_member.destroy @project_member.destroy
>>>>>>> ce/8-2-stable
log_audit_event(@project_member, action: :destroy)
respond_to do |format| respond_to do |format|
format.html { redirect_to dashboard_projects_path, notice: "You left the project." } format.html { redirect_to dashboard_projects_path, notice: "You left the project." }
......
...@@ -5,7 +5,6 @@ class Ability ...@@ -5,7 +5,6 @@ class Ability
return [] unless user.kind_of?(User) return [] unless user.kind_of?(User)
return [] if user.blocked? return [] if user.blocked?
<<<<<<< HEAD
abilities = abilities =
case subject.class.name case subject.class.name
when "Project" then project_abilities(user, subject) when "Project" then project_abilities(user, subject)
...@@ -17,6 +16,7 @@ class Ability ...@@ -17,6 +16,7 @@ class Ability
when "Group" then group_abilities(user, subject) when "Group" then group_abilities(user, subject)
when "Namespace" then namespace_abilities(user, subject) when "Namespace" then namespace_abilities(user, subject)
when "GroupMember" then group_member_abilities(user, subject) when "GroupMember" then group_member_abilities(user, subject)
when "ProjectMember" then project_member_abilities(user, subject)
else [] else []
end end
...@@ -34,21 +34,6 @@ class Ability ...@@ -34,21 +34,6 @@ class Ability
:push_code, :push_code,
:push_code_to_protected_branches :push_code_to_protected_branches
] ]
=======
case subject.class.name
when "Project" then project_abilities(user, subject)
when "Issue" then issue_abilities(user, subject)
when "Note" then note_abilities(user, subject)
when "ProjectSnippet" then project_snippet_abilities(user, subject)
when "PersonalSnippet" then personal_snippet_abilities(user, subject)
when "MergeRequest" then merge_request_abilities(user, subject)
when "Group" then group_abilities(user, subject)
when "Namespace" then namespace_abilities(user, subject)
when "GroupMember" then group_member_abilities(user, subject)
when "ProjectMember" then project_member_abilities(user, subject)
else []
end.concat(global_abilities(user))
>>>>>>> ce/8-2-stable
end end
# List of possible abilities # List of possible abilities
...@@ -275,15 +260,11 @@ class Ability ...@@ -275,15 +260,11 @@ class Ability
:admin_group, :admin_group,
:admin_namespace, :admin_namespace,
:admin_group_member :admin_group_member
<<<<<<< HEAD ]
])
unless group.ldap_synced? if group.ldap_synced?
rules << :admin_group_member rules.delete(:admin_group_member)
end end
=======
]
>>>>>>> ce/8-2-stable
end end
rules.flatten rules.flatten
......
...@@ -96,23 +96,19 @@ class Member < ActiveRecord::Base ...@@ -96,23 +96,19 @@ class Member < ActiveRecord::Base
member.created_by ||= current_user member.created_by ||= current_user
member.access_level = access_level member.access_level = access_level
member.skip_notification = skip_notification
member.save member.save
end end
end end
private private
<<<<<<< HEAD
member.skip_notification = skip_notification
member.save
=======
def can_update_member?(current_user, member) def can_update_member?(current_user, member)
# There is no current user for bulk actions, in which case anything is allowed # There is no current user for bulk actions, in which case anything is allowed
!current_user || !current_user ||
current_user.can?(:update_group_member, member) || current_user.can?(:update_group_member, member) ||
current_user.can?(:update_project_member, member) current_user.can?(:update_project_member, member)
>>>>>>> ce/8-2-stable
end end
end end
......
...@@ -336,7 +336,6 @@ class Project < ActiveRecord::Base ...@@ -336,7 +336,6 @@ class Project < ActiveRecord::Base
end end
def add_import_job def add_import_job
<<<<<<< HEAD
if repository_exists? if repository_exists?
if mirror? if mirror?
RepositoryUpdateMirrorWorker.perform_async(self.id) RepositoryUpdateMirrorWorker.perform_async(self.id)
...@@ -345,8 +344,6 @@ class Project < ActiveRecord::Base ...@@ -345,8 +344,6 @@ class Project < ActiveRecord::Base
return return
end end
=======
>>>>>>> ce/8-2-stable
if forked? if forked?
RepositoryForkWorker.perform_async(self.id, forked_from_project.path_with_namespace, self.namespace.path) RepositoryForkWorker.perform_async(self.id, forked_from_project.path_with_namespace, self.namespace.path)
else else
...@@ -394,7 +391,6 @@ class Project < ActiveRecord::Base ...@@ -394,7 +391,6 @@ class Project < ActiveRecord::Base
original_url original_url
end end
<<<<<<< HEAD
def mirror_updated? def mirror_updated?
mirror? && self.mirror_last_update_at mirror? && self.mirror_last_update_at
end end
...@@ -443,8 +439,6 @@ class Project < ActiveRecord::Base ...@@ -443,8 +439,6 @@ class Project < ActiveRecord::Base
repository.fetch_upstream(self.import_url) repository.fetch_upstream(self.import_url)
end end
=======
>>>>>>> ce/8-2-stable
def check_limit def check_limit
unless creator.can_create_project? or namespace.kind == 'group' unless creator.can_create_project? or namespace.kind == 'group'
errors[:limit_reached] << ("Your project limit is #{creator.projects_limit} projects! Please contact your administrator to increase it") errors[:limit_reached] << ("Your project limit is #{creator.projects_limit} projects! Please contact your administrator to increase it")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment