Merge branch 'pl-spec-helper-error-tracking-stubbed' into 'master'

Use stubbed objects in error_tracking_helper spec

See merge request gitlab-org/gitlab!82719

spec/factories/projects.rb

@@ -388,6 +388,10 @@ FactoryBot.define do
     service_desk_enabled { true }
   end
 
+  trait :with_error_tracking_setting do
+    error_tracking_setting { association :project_error_tracking_setting }
+  end
+
   # Project with empty repository
   #
   # This is a case when you just created a project

spec/helpers/projects/error_tracking_helper_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 RSpec.describe Projects::ErrorTrackingHelper do
   include Gitlab::Routing.url_helpers
 
-  let_it_be(:project, reload: true) { create(:project) }
-  let_it_be(:current_user) { create(:user) }
+  let(:project) { build_stubbed(:project) }
+  let(:current_user) { build_stubbed(:user) }
 
   describe '#error_tracking_data' do
     let(:can_enable_error_tracking) { true }
@@ -41,15 +41,15 @@ RSpec.describe Projects::ErrorTrackingHelper do
     end
 
     context 'with error_tracking_setting' do
-      let(:error_tracking_setting) do
-        create(:project_error_tracking_setting, project: project)
-      end
+      let(:project) { build_stubbed(:project, :with_error_tracking_setting) }
 
-      context 'when enabled' do
       before do
-          error_tracking_setting.update!(enabled: true)
+        project.error_tracking_setting.enabled = enabled
       end
 
+      context 'when enabled' do
+        let(:enabled) { true }
+
         it 'show error tracking enabled' do
           expect(helper.error_tracking_data(current_user, project)).to include(
             'error-tracking-enabled' => 'true'
@@ -58,9 +58,7 @@ RSpec.describe Projects::ErrorTrackingHelper do
       end
 
       context 'when disabled' do
-        before do
-          error_tracking_setting.update!(enabled: false)
-        end
+        let(:enabled) { false }
 
         it 'show error tracking not enabled' do
           expect(helper.error_tracking_data(current_user, project)).to include(
@@ -86,10 +84,11 @@ RSpec.describe Projects::ErrorTrackingHelper do
         with_them do
           before do
             stub_feature_flags(integrated_error_tracking: feature_flag)
-            error_tracking_setting.update_columns(
+
+            project.error_tracking_setting.attributes = {
               enabled: enabled,
               integrated: integrated
-            )
+            }
           end
 
           specify do