Commit 3cdac383 authored by ddash2's avatar ddash2

Use getters instead of instance variables

parent 2b06da87
...@@ -10,13 +10,13 @@ module Notes ...@@ -10,13 +10,13 @@ module Notes
def execute def execute
# Skip system notes, like status changes and cross-references and awards # Skip system notes, like status changes and cross-references and awards
unless @note.system? unless note.system?
EventCreateService.new.leave_note(@note, @note.author) EventCreateService.new.leave_note(note, note.author)
return if @note.for_personal_snippet? return if note.for_personal_snippet?
@note.create_cross_references! note.create_cross_references!
::SystemNoteService.design_discussion_added(@note) if create_design_discussion_system_note? ::SystemNoteService.design_discussion_added(note) if create_design_discussion_system_note?
execute_note_hooks execute_note_hooks
end end
...@@ -25,21 +25,21 @@ module Notes ...@@ -25,21 +25,21 @@ module Notes
private private
def create_design_discussion_system_note? def create_design_discussion_system_note?
@note && @note.for_design? && @note.start_of_discussion? note && note.for_design? && note.start_of_discussion?
end end
def hook_data def hook_data
Gitlab::DataBuilder::Note.build(@note, @note.author) Gitlab::DataBuilder::Note.build(note, note.author)
end end
def execute_note_hooks def execute_note_hooks
return unless @note.project return unless note.project
note_data = hook_data note_data = hook_data
hooks_scope = @note.confidential?(include_noteable: true) ? :confidential_note_hooks : :note_hooks hooks_scope = note.confidential?(include_noteable: true) ? :confidential_note_hooks : :note_hooks
@note.project.execute_hooks(note_data, hooks_scope) note.project.execute_hooks(note_data, hooks_scope)
@note.project.execute_services(note_data, hooks_scope) note.project.execute_services(note_data, hooks_scope)
end end
end end
end end
......
...@@ -41,7 +41,7 @@ module Notes ...@@ -41,7 +41,7 @@ module Notes
@interpret_service = QuickActions::InterpretService.new(project, current_user, options) @interpret_service = QuickActions::InterpretService.new(project, current_user, options)
@interpret_service.execute(note.note, note.noteable) interpret_service.execute(note.note, note.noteable)
end end
# Applies updates extracted to note#noteable # Applies updates extracted to note#noteable
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment