Merge branch 'al-11846-add-specs-for-retrying-web-ide-terminal-build' into 'master'

Add more specs for Projects::WebIdeTerminalsController#retry

See merge request gitlab-org/gitlab!26603

ee/spec/controllers/projects/web_ide_terminals_controller_spec.rb

@@ -3,13 +3,13 @@
 require 'spec_helper'
 
 describe Projects::WebIdeTerminalsController do
-  let(:owner) { create(:owner) }
-  let(:admin) { create(:admin) }
-  let(:maintainer) { create(:user) }
-  let(:developer) { create(:user) }
-  let(:reporter) { create(:user) }
-  let(:guest) { create(:user) }
-  let(:project) { create(:project, :private, :repository, namespace: owner.namespace) }
+  let_it_be(:owner) { create(:owner) }
+  let_it_be(:admin) { create(:admin) }
+  let_it_be(:maintainer) { create(:user) }
+  let_it_be(:developer) { create(:user) }
+  let_it_be(:reporter) { create(:user) }
+  let_it_be(:guest) { create(:user) }
+  let_it_be(:project) { create(:project, :private, :repository, namespace: owner.namespace) }
   let(:pipeline) { create(:ci_pipeline, project: project, source: :webide, config_source: :webide_source, user: user) }
   let(:job) { create(:ci_build, pipeline: pipeline, user: user, project: project) }
   let(:user) { maintainer }
@@ -206,7 +206,8 @@ describe Projects::WebIdeTerminalsController do
   end
 
   describe 'POST retry' do
-    let(:job) { create(:ci_build, :failed, pipeline: pipeline, user: user, project: project) }
+    let(:status) { :failed }
+    let(:job) { create(:ci_build, status, pipeline: pipeline, user: user, project: project) }
 
     before do
       post(:retry, params: {
@@ -220,11 +221,35 @@ describe Projects::WebIdeTerminalsController do
     it_behaves_like 'when pipeline is not from a webide source'
 
     context 'when job is not retryable' do
-      let!(:job) { create(:ci_build, :running, pipeline: pipeline, user: user) }
+      let(:status) { :running }
 
       it 'returns 422' do
         expect(response).to have_gitlab_http_status(:unprocessable_entity)
       end
     end
+
+    context 'when job is cancelled' do
+      let(:status) { :canceled }
+
+      it 'returns 200' do
+        expect(response).to have_gitlab_http_status(:ok)
+      end
+    end
+
+    context 'when job fails' do
+      let(:status) { :failed }
+
+      it 'returns 200' do
+        expect(response).to have_gitlab_http_status(:ok)
+      end
+    end
+
+    context 'when job is successful' do
+      let(:status) { :success }
+
+      it 'returns 200' do
+        expect(response).to have_gitlab_http_status(:ok)
+      end
+    end
   end
 end