Commit 4035dda6 authored by Martin Wortschack's avatar Martin Wortschack

Merge branch '42677-neaten-up-tooltip-styling-on-cycle-analytics-duration-chart' into 'master'

Resolve "Neaten up tooltip styling on cycle analytics duration chart"

Closes #42677

See merge request gitlab-org/gitlab!22883
parents 6b45f448 4e90e758
...@@ -8,10 +8,10 @@ import { PROJECTS_PER_PAGE, DEFAULT_DAYS_IN_PAST } from '../constants'; ...@@ -8,10 +8,10 @@ import { PROJECTS_PER_PAGE, DEFAULT_DAYS_IN_PAST } from '../constants';
import GroupsDropdownFilter from '../../shared/components/groups_dropdown_filter.vue'; import GroupsDropdownFilter from '../../shared/components/groups_dropdown_filter.vue';
import ProjectsDropdownFilter from '../../shared/components/projects_dropdown_filter.vue'; import ProjectsDropdownFilter from '../../shared/components/projects_dropdown_filter.vue';
import Scatterplot from '../../shared/components/scatterplot.vue'; import Scatterplot from '../../shared/components/scatterplot.vue';
import { LAST_ACTIVITY_AT, dateFormats } from '../../shared/constants';
import StageDropdownFilter from './stage_dropdown_filter.vue'; import StageDropdownFilter from './stage_dropdown_filter.vue';
import SummaryTable from './summary_table.vue'; import SummaryTable from './summary_table.vue';
import StageTable from './stage_table.vue'; import StageTable from './stage_table.vue';
import { LAST_ACTIVITY_AT } from '../../shared/constants';
import TasksByTypeChart from './tasks_by_type_chart.vue'; import TasksByTypeChart from './tasks_by_type_chart.vue';
export default { export default {
...@@ -196,6 +196,7 @@ export default { ...@@ -196,6 +196,7 @@ export default {
with_shared: false, with_shared: false,
order_by: LAST_ACTIVITY_AT, order_by: LAST_ACTIVITY_AT,
}, },
durationChartTooltipDateFormat: dateFormats.defaultDate,
}; };
</script> </script>
...@@ -308,6 +309,7 @@ export default { ...@@ -308,6 +309,7 @@ export default {
v-if="durationChartPlottableData" v-if="durationChartPlottableData"
:x-axis-title="s__('CycleAnalytics|Date')" :x-axis-title="s__('CycleAnalytics|Date')"
:y-axis-title="s__('CycleAnalytics|Total days to completion')" :y-axis-title="s__('CycleAnalytics|Total days to completion')"
:tooltip-date-format="$options.durationChartTooltipDateFormat"
:scatter-data="durationChartPlottableData" :scatter-data="durationChartPlottableData"
/> />
<div v-else ref="duration-chart-no-data" class="bs-callout bs-callout-info"> <div v-else ref="duration-chart-no-data" class="bs-callout bs-callout-info">
......
...@@ -25,6 +25,11 @@ export default { ...@@ -25,6 +25,11 @@ export default {
required: false, required: false,
default: () => [], default: () => [],
}, },
tooltipDateFormat: {
type: String,
required: false,
default: dateFormats.defaultDateTime,
},
}, },
data() { data() {
return { return {
...@@ -69,7 +74,7 @@ export default { ...@@ -69,7 +74,7 @@ export default {
methods: { methods: {
renderTooltip({ data }) { renderTooltip({ data }) {
const [, metric, dateTime] = data; const [, metric, dateTime] = data;
this.tooltipTitle = dateFormat(dateTime, dateFormats.defaultDateTime); this.tooltipTitle = dateFormat(dateTime, this.tooltipDateFormat);
this.tooltipContent = metric; this.tooltipContent = metric;
}, },
}, },
...@@ -86,7 +91,7 @@ export default { ...@@ -86,7 +91,7 @@ export default {
> >
<div slot="tooltipTitle">{{ tooltipTitle }} ({{ xAxisTitle }})</div> <div slot="tooltipTitle">{{ tooltipTitle }} ({{ xAxisTitle }})</div>
<div slot="tooltipContent" class="d-flex"> <div slot="tooltipContent" class="d-flex">
<div class="flex-grow-1">{{ yAxisTitle }}</div> <div class="flex-grow-1">{{ yAxisTitle }}:&nbsp;</div>
<div class="font-weight-bold">{{ tooltipContent }}</div> <div class="font-weight-bold">{{ tooltipContent }}</div>
</div> </div>
</gl-discrete-scatter-chart> </gl-discrete-scatter-chart>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment