Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4162ce60
Commit
4162ce60
authored
Jan 12, 2022
by
Justin Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update controller query to avoid N+1
Also fix name of emitted event
parent
972562b4
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
3 deletions
+3
-3
ee/app/assets/javascripts/integrations/gitlab_slack_application/components/projects_dropdown.vue
...gitlab_slack_application/components/projects_dropdown.vue
+1
-1
ee/app/controllers/profiles/slacks_controller.rb
ee/app/controllers/profiles/slacks_controller.rb
+1
-1
ee/spec/helpers/ee/integrations_helper_spec.rb
ee/spec/helpers/ee/integrations_helper_spec.rb
+1
-1
No files found.
ee/app/assets/javascripts/integrations/gitlab_slack_application/components/projects_dropdown.vue
View file @
4162ce60
...
...
@@ -35,7 +35,7 @@ export default {
},
methods
:
{
onClick
(
project
)
{
this
.
$emit
(
'
project
S
elected
'
,
project
);
this
.
$emit
(
'
project
-s
elected
'
,
project
);
this
.
$refs
.
dropdown
.
hide
(
true
);
},
},
...
...
ee/app/controllers/profiles/slacks_controller.rb
View file @
4162ce60
...
...
@@ -10,7 +10,7 @@ class Profiles::SlacksController < Profiles::ApplicationController
feature_category
:users
def
edit
@projects
=
disabled_projects
if
current_user
@projects
=
disabled_projects
.
inc_routes
if
current_user
end
def
slack_link
...
...
ee/spec/helpers/ee/integrations_helper_spec.rb
View file @
4162ce60
...
...
@@ -112,7 +112,7 @@ RSpec.describe EE::IntegrationsHelper do
let_it_be
(
:projects
)
{
create_list
(
:project
,
3
)
}
def
relation
Project
.
id_in
(
projects
.
pluck
(
:id
))
Project
.
id_in
(
projects
.
pluck
(
:id
))
.
inc_routes
end
let
(
:request
)
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment