Merge branch 'ntepluhina-intersection-observer' into 'master'

Lazy-loading design images with IntersectionObserver

See merge request gitlab-org/gitlab!28555

ee/app/assets/javascripts/design_management/components/list/item.vue

 <script>
-import { GlLoadingIcon } from '@gitlab/ui';
+import { GlLoadingIcon, GlIntersectionObserver } from '@gitlab/ui';
 import Icon from '~/vue_shared/components/icon.vue';
 import Timeago from '~/vue_shared/components/time_ago_tooltip.vue';
 import { n__, __ } from '~/locale';
@@ -8,6 +8,7 @@ import { DESIGN_ROUTE_NAME } from '../../router/constants';
 export default {
   components: {
     GlLoadingIcon,
+    GlIntersectionObserver,
     Icon,
     Timeago,
   },
@@ -46,6 +47,7 @@ export default {
   data() {
     return {
       imageLoading: true,
+      isInView: false,
     };
   },
   computed: {
@@ -77,6 +79,9 @@ export default {
     showLoadingSpinner() {
       return this.imageLoading || this.isUploading;
     },
+    imageLink() {
+      return this.isInView ? this.image : '';
+    },
   },
   methods: {
     onImageLoad() {
@@ -103,14 +108,16 @@ export default {
         </span>
       </div>
       <gl-loading-icon v-show="showLoadingSpinner" size="md" />
+      <gl-intersection-observer @appear="isInView = true">
         <img
           v-show="!showLoadingSpinner"
-        :src="image"
+          :src="imageLink"
           :alt="filename"
-        class="block ml-auto mr-auto mw-100 mh-100 design-img"
+          class="block mx-auto mw-100 mh-100 design-img"
           data-qa-selector="design_image"
           @load="onImageLoad"
         />
+      </gl-intersection-observer>
     </div>
     <div class="card-footer d-flex w-100">
       <div class="d-flex flex-column str-truncated-100">

ee/changelogs/unreleased/ntepluhina-intersection-observer.yml

+---
+title: Lazy-loading design images with IntersectionObserver
+merge_request: 28555
+author:
+type: added

ee/spec/frontend/design_management/components/list/__snapshots__/item_spec.js.snap

@@ -30,12 +30,16 @@ exports[`Design management list item component with no notes renders item with c
       style="display: none;"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div
@@ -99,12 +103,16 @@ exports[`Design management list item component with no notes renders item with c
       style="display: none;"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div
@@ -168,12 +176,16 @@ exports[`Design management list item component with no notes renders item with c
       style="display: none;"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div
@@ -224,12 +236,16 @@ exports[`Design management list item component with no notes renders item with n
       style="display: none;"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div
@@ -279,13 +295,17 @@ exports[`Design management list item component with no notes renders loading spi
       size="md"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
         style="display: none;"
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div
@@ -336,12 +356,16 @@ exports[`Design management list item component with notes renders item with mult
       style="display: none;"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div
@@ -409,12 +433,16 @@ exports[`Design management list item component with notes renders item with sing
       style="display: none;"
     />
      
+    <gl-intersection-observer-stub
+      options="[object Object]"
+    >
       <img
         alt="test"
-      class="block ml-auto mr-auto mw-100 mh-100 design-img"
+        class="block mx-auto mw-100 mh-100 design-img"
         data-qa-selector="design_image"
-      src="http://via.placeholder.com/300"
+        src=""
       />
+    </gl-intersection-observer-stub>
   </div>
    
   <div

ee/spec/frontend/design_management/components/list/item_spec.js

 import { createLocalVue, shallowMount } from '@vue/test-utils';
 import VueRouter from 'vue-router';
 import Item from 'ee/design_management/components/list/item.vue';
+import { GlIntersectionObserver } from '@gitlab/ui';
 
 const localVue = createLocalVue();
 localVue.use(VueRouter);
@@ -47,6 +48,19 @@ describe('Design management list item component', () => {
     wrapper.destroy();
   });
 
+  it('renders an image when it appears in view', () => {
+    createComponent();
+    const image = wrapper.find('img');
+
+    expect(image.attributes('src')).toBe('');
+
+    wrapper.find(GlIntersectionObserver).vm.$emit('appear');
+
+    return wrapper.vm.$nextTick().then(() => {
+      expect(image.attributes('src')).toBe('http://via.placeholder.com/300');
+    });
+  });
+
   describe('with notes', () => {
     it('renders item with single comment', () => {
       createComponent({ notesCount: 1 });