Merge branch '351073-cleanup-publish-project-deleted-event-flag' into 'master'

Clean up feature flag publish_project_deleted_event to enable by default

See merge request gitlab-org/gitlab!80875

app/services/projects/destroy_service.rb

@@ -37,7 +37,7 @@ module Projects
       system_hook_service.execute_hooks_for(project, :destroy)
       log_info("Project \"#{project.full_path}\" was deleted")
 
-      publish_project_deleted_event_for(project) if Feature.enabled?(:publish_project_deleted_event, default_enabled: :yaml)
+      publish_project_deleted_event_for(project)
 
       current_user.invalidate_personal_projects_count
 

config/feature_flags/development/publish_project_deleted_event.yml

----
-name: publish_project_deleted_event
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/78862
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/351073
-milestone: '14.8'
-type: development
-group: group::pipeline insights
-default_enabled: false

spec/services/projects/destroy_service_spec.rb

@@ -36,18 +36,6 @@ RSpec.describe Projects::DestroyService, :aggregate_failures do
 
       destroy_project(project, user, {})
     end
-
-    context 'when feature flag publish_project_deleted_event is disabled' do
-      before do
-        stub_feature_flags(publish_project_deleted_event: false)
-      end
-
-      it 'does not publish an event' do
-        expect(Gitlab::EventStore).not_to receive(:publish).with(event_type(Projects::ProjectDeletedEvent))
-
-        destroy_project(project, user, {})
-      end
-    end
   end
 
   shared_examples 'deleting the project with pipeline and build' do