Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4cf45a52
Commit
4cf45a52
authored
Oct 31, 2017
by
Filipa Lacerda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adds line number in the path
parent
f7eb7336
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
13 additions
and
7 deletions
+13
-7
app/assets/stylesheets/pages/merge_requests.scss
app/assets/stylesheets/pages/merge_requests.scss
+1
-1
ee/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_code_quality_issues.vue
...quest_widget/components/mr_widget_code_quality_issues.vue
+1
-1
spec/javascripts/vue_mr_widget/components/mr_widget_code_quality_issues_spec.js
...r_widget/components/mr_widget_code_quality_issues_spec.js
+10
-4
spec/javascripts/vue_mr_widget/mock_data.js
spec/javascripts/vue_mr_widget/mock_data.js
+1
-1
No files found.
app/assets/stylesheets/pages/merge_requests.scss
View file @
4cf45a52
...
...
@@ -790,7 +790,7 @@
.mr-widget-code-quality-list
{
list-style
:
none
;
padding
:
4
px
36px
;
padding
:
0
px
36px
;
margin
:
0
;
line-height
:
$code_line_height
;
...
...
ee/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_code_quality_issues.vue
View file @
4cf45a52
...
...
@@ -60,7 +60,7 @@
:href=
"issue.location.urlPath"
target=
"_blank"
rel=
"noopener noreferrer nofollow"
>
{{issue.location.path}}
{{issue.location.path}}
<
template
v-if=
"issue.location.lines && issue.location.lines.begin"
>
:
{{
issue
.
location
.
lines
.
begin
}}
</
template
>
</a>
</li>
</ul>
...
...
spec/javascripts/vue_mr_widget/components/mr_widget_code_quality_issues_spec.js
View file @
4cf45a52
...
...
@@ -22,7 +22,9 @@ describe('merge request code quality issues', () => {
path
:
'
bar
'
,
urlPath
:
'
foo
'
,
positions
:
'
81
'
,
lines
:
'
21
'
,
lines
:
{
begin
:
'
21
'
,
},
},
}],
});
...
...
@@ -31,7 +33,7 @@ describe('merge request code quality issues', () => {
it
(
'
should render issue
'
,
()
=>
{
expect
(
vm
.
$el
.
querySelector
(
'
li
'
).
textContent
.
trim
().
replace
(
/
\s
+/g
,
''
),
).
toEqual
(
'
Fixed:fooinbar
'
);
).
toEqual
(
'
Fixed:fooinbar
:21
'
);
});
});
...
...
@@ -44,7 +46,9 @@ describe('merge request code quality issues', () => {
location
:
{
path
:
'
bar
'
,
positions
:
'
81
'
,
lines
:
'
21
'
,
lines
:
{
begin
:
'
21
'
,
},
},
}],
});
...
...
@@ -65,7 +69,9 @@ describe('merge request code quality issues', () => {
location
:
{
path
:
'
bar
'
,
positions
:
'
81
'
,
lines
:
'
21
'
,
lines
:
{
begin
:
'
21
'
,
},
},
}],
});
...
...
spec/javascripts/vue_mr_widget/mock_data.js
View file @
4cf45a52
...
...
@@ -268,4 +268,4 @@ export const baseIssues = [
},
"
fingerprint
"
:
"
ca2354534dee94ae60ba2f54e3857c50e5
"
,
}
]
]
;
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment