Commit 4dfe7178 authored by Sean McGivern's avatar Sean McGivern

Merge branch 'issue_55133' into 'master'

Fix issuables sort direction button parameters

Closes #55133

See merge request gitlab-org/gitlab-ce!23744
parents b42b53c1 61ad1da1
...@@ -164,7 +164,7 @@ module SortingHelper ...@@ -164,7 +164,7 @@ module SortingHelper
reverse_sort = issuable_reverse_sort_order_hash[sort_value] reverse_sort = issuable_reverse_sort_order_hash[sort_value]
if reverse_sort if reverse_sort
reverse_url = page_filter_path(sort: reverse_sort) reverse_url = page_filter_path(sort: reverse_sort, label: true)
else else
reverse_url = '#' reverse_url = '#'
link_class += ' disabled' link_class += ' disabled'
......
...@@ -21,7 +21,11 @@ describe SortingHelper do ...@@ -21,7 +21,11 @@ describe SortingHelper do
describe '#issuable_sort_direction_button' do describe '#issuable_sort_direction_button' do
before do before do
allow(self).to receive(:request).and_return(double(path: 'http://test.com', query_parameters: {})) allow(self).to receive(:request).and_return(double(path: 'http://test.com', query_parameters: { label_name: 'test_label' }))
end
it 'keeps label filter param' do
expect(issuable_sort_direction_button('created_date')).to include('label_name=test_label')
end end
it 'returns icon with sort-highest when sort is created_date' do it 'returns icon with sort-highest when sort is created_date' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment