Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
4fae3997
Commit
4fae3997
authored
Feb 01, 2021
by
Kamil Trzciński
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove `ci_pipeline_open_merge_requests` FF
This feature is stable and no longer needs a feature flag.
parent
bb19877a
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
13 deletions
+1
-13
app/models/ci/pipeline.rb
app/models/ci/pipeline.rb
+1
-1
config/feature_flags/development/ci_pipeline_open_merge_requests.yml
...ure_flags/development/ci_pipeline_open_merge_requests.yml
+0
-8
lib/gitlab/ci/features.rb
lib/gitlab/ci/features.rb
+0
-4
No files found.
app/models/ci/pipeline.rb
View file @
4fae3997
...
@@ -803,7 +803,7 @@ module Ci
...
@@ -803,7 +803,7 @@ module Ci
variables
.
concat
(
merge_request
.
predefined_variables
)
variables
.
concat
(
merge_request
.
predefined_variables
)
end
end
if
Gitlab
::
Ci
::
Features
.
pipeline_open_merge_requests?
(
project
)
&&
open_merge_requests_refs
.
any?
if
open_merge_requests_refs
.
any?
variables
.
append
(
key:
'CI_OPEN_MERGE_REQUESTS'
,
value:
open_merge_requests_refs
.
join
(
','
))
variables
.
append
(
key:
'CI_OPEN_MERGE_REQUESTS'
,
value:
open_merge_requests_refs
.
join
(
','
))
end
end
...
...
config/feature_flags/development/ci_pipeline_open_merge_requests.yml
deleted
100644 → 0
View file @
bb19877a
---
name
:
ci_pipeline_open_merge_requests
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/38673
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/292727
milestone
:
'
13.7'
group
:
group::memory
type
:
development
default_enabled
:
true
lib/gitlab/ci/features.rb
View file @
4fae3997
...
@@ -55,10 +55,6 @@ module Gitlab
...
@@ -55,10 +55,6 @@ module Gitlab
::
Feature
.
enabled?
(
:ci_trace_log_invalid_chunks
,
project
,
type: :ops
,
default_enabled:
false
)
::
Feature
.
enabled?
(
:ci_trace_log_invalid_chunks
,
project
,
type: :ops
,
default_enabled:
false
)
end
end
def
self
.
pipeline_open_merge_requests?
(
project
)
::
Feature
.
enabled?
(
:ci_pipeline_open_merge_requests
,
project
,
default_enabled:
true
)
end
def
self
.
ci_pipeline_editor_page_enabled?
(
project
)
def
self
.
ci_pipeline_editor_page_enabled?
(
project
)
::
Feature
.
enabled?
(
:ci_pipeline_editor_page
,
project
,
default_enabled: :yaml
)
::
Feature
.
enabled?
(
:ci_pipeline_editor_page
,
project
,
default_enabled: :yaml
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment