Commit 5073e727 authored by Martin Wortschack's avatar Martin Wortschack

Address reviewer feedback

parent 9fc42a55
...@@ -89,9 +89,7 @@ export default { ...@@ -89,9 +89,7 @@ export default {
<h5 v-if="title">{{ title }}</h5> <h5 v-if="title">{{ title }}</h5>
<gl-loading-icon v-if="isLoading" size="md" class="my-4 py-4" /> <gl-loading-icon v-if="isLoading" size="md" class="my-4 py-4" />
<template v-else> <template v-else>
<gl-alert v-if="infoMessage" :dismissible="false"> <gl-alert v-if="infoMessage" :dismissible="false">{{ infoMessage }}</gl-alert>
{{ infoMessage }}
</gl-alert>
<template v-else> <template v-else>
<gl-deprecated-dropdown <gl-deprecated-dropdown
v-if="hasMetricTypes" v-if="hasMetricTypes"
......
...@@ -13,9 +13,7 @@ exports[`MetricChart component template when isLoading is false and chart data i ...@@ -13,9 +13,7 @@ exports[`MetricChart component template when isLoading is false and chart data i
title="" title=""
variant="info" variant="info"
> >
There is no data available. Please change your selection. There is no data available. Please change your selection.
</gl-alert-stub> </gl-alert-stub>
</div> </div>
`; `;
......
...@@ -101,7 +101,7 @@ describe('MetricChart component', () => { ...@@ -101,7 +101,7 @@ describe('MetricChart component', () => {
describe('and there is no error', () => { describe('and there is no error', () => {
it('shows a "no data" info text', () => { it('shows a "no data" info text', () => {
expect(findInfoMessage().text()).toContain( expect(findInfoMessage().text()).toBe(
'There is no data available. Please change your selection.', 'There is no data available. Please change your selection.',
); );
}); });
...@@ -111,7 +111,7 @@ describe('MetricChart component', () => { ...@@ -111,7 +111,7 @@ describe('MetricChart component', () => {
it('shows a "too much data" info text', () => { it('shows a "too much data" info text', () => {
factory({ isLoading, chartData: [], errorCode: httpStatusCodes.INTERNAL_SERVER_ERROR }); factory({ isLoading, chartData: [], errorCode: httpStatusCodes.INTERNAL_SERVER_ERROR });
expect(findInfoMessage().text()).toContain( expect(findInfoMessage().text()).toBe(
'There is too much data to calculate. Please change your selection.', 'There is too much data to calculate. Please change your selection.',
); );
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment