Clearing licensed feature caches is not necessary anymore

ee/spec/requests/api/project_mirror_spec.rb

@@ -293,7 +293,6 @@ RSpec.describe API::ProjectMirror do
           context 'when repository_mirrors feature is not available' do
             before do
               stub_licensed_features(repository_mirrors: false)
-              project_mirrored.clear_memoization(:licensed_feature_available)
             end
 
             it_behaves_like 'an API endpoint that does not trigger pull mirroring operation', :bad_request
@@ -302,7 +301,6 @@ RSpec.describe API::ProjectMirror do
           context 'when repository_mirrors feature is available' do
             before do
               stub_licensed_features(repository_mirrors: true)
-              project_mirrored.clear_memoization(:licensed_feature_available)
             end
 
             it_behaves_like 'an API endpoint that triggers pull mirroring operation'

ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb

@@ -165,7 +165,6 @@ RSpec.describe Ci::ExternalPullRequests::ProcessGithubEventService do
       let(:source_sha) { double }
 
       before do
-        project.clear_memoization(:licensed_feature_available)
         allow(project).to receive(:mirror?).and_return(true)
         stub_licensed_features(ci_cd_projects: false, github_project_service_integration: false)
       end

ee/spec/services/dast/profiles/create_service_spec.rb

@@ -16,10 +16,6 @@ RSpec.describe Dast::Profiles::CreateService do
   subject { described_class.new(container: project, current_user: developer, params: params).execute }
 
   describe 'execute' do
-    before do
-      project.clear_memoization(:licensed_feature_available)
-    end
-
     context 'when on demand scan feature is disabled' do
       it 'communicates failure' do
         stub_licensed_features(security_on_demand_scans: true)

ee/spec/services/dast/profiles/destroy_service_spec.rb

@@ -18,10 +18,6 @@ RSpec.describe Dast::Profiles::DestroyService do
   end
 
   describe '#execute' do
-    before do
-      project.clear_memoization(:licensed_feature_available)
-    end
-
     context 'when the feature flag dast_saved_scans is disabled' do
       it 'communicates failure' do
         stub_licensed_features(security_on_demand_scans: true)

ee/spec/services/dast/profiles/update_service_spec.rb

@@ -30,10 +30,6 @@ RSpec.describe Dast::Profiles::UpdateService do
   end
 
   describe 'execute', :clean_gitlab_redis_shared_state do
-    before do
-      project.clear_memoization(:licensed_feature_available)
-    end
-
     context 'when on demand scan feature is disabled' do
       it 'communicates failure' do
         stub_licensed_features(security_on_demand_scans: true)

ee/spec/services/dast_site_validations/create_service_spec.rb

@@ -12,10 +12,6 @@ RSpec.describe DastSiteValidations::CreateService do
   subject { described_class.new(container: dast_site.project, params: params).execute }
 
   describe 'execute', :clean_gitlab_redis_shared_state do
-    before do
-      project.clear_memoization(:licensed_feature_available)
-    end
-
     context 'when on demand scan feature is disabled' do
       it 'communicates failure' do
         stub_licensed_features(security_on_demand_scans: true)

ee/spec/services/dast_site_validations/revoke_service_spec.rb

@@ -16,10 +16,6 @@ RSpec.describe DastSiteValidations::RevokeService do
   subject { described_class.new(container: project, params: params).execute }
 
   describe 'execute', :clean_gitlab_redis_shared_state do
-    before do
-      project.clear_memoization(:licensed_feature_available)
-    end
-
     context 'when on demand scan feature is disabled' do
       it 'communicates failure' do
         stub_licensed_features(security_on_demand_scans: true)

ee/spec/services/projects/prometheus/alerts/notify_service_spec.rb

@@ -16,11 +16,6 @@ RSpec.describe Projects::Prometheus::Alerts::NotifyService do
 
   let(:subject) { service.execute(token_input) }
 
-  before do
-    # We use `let_it_be(:project)` so we make sure to clear caches
-    project.clear_memoization(:licensed_feature_available)
-  end
-
   context 'with valid payload' do
     let(:alert_firing) { create(:prometheus_alert, project: project) }
     let(:alert_resolved) { create(:prometheus_alert, project: project) }

spec/support/shared_contexts/services_shared_context.rb

@@ -62,7 +62,6 @@ Service.available_services_names.each do |service|
 
       stub_licensed_features(licensed_feature => true)
       project.clear_memoization(:disabled_services)
-      project.clear_memoization(:licensed_feature_available)
     end
   end
 end