Commit 58565ac5 authored by Simon Knox's avatar Simon Knox

Merge branch 'issue-board-edit-modal' into edit-board

parents 9b802ed9 32ac090e
...@@ -22,6 +22,7 @@ ...@@ -22,6 +22,7 @@
Board name Board name
</label> </label>
<input <input
ref="name"
class="form-control" class="form-control"
type="text" type="text"
id="board-new-name" id="board-new-name"
...@@ -64,7 +65,7 @@ ...@@ -64,7 +65,7 @@
<board-milestone-select <board-milestone-select
:board="board" :board="board"
:milestone-path="milestonePath" :milestone-path="milestonePath"
v-model="board.milestone"> v-model="board.milestone_id">
</board-milestone-select> </board-milestone-select>
</form-block> </form-block>
...@@ -154,6 +155,9 @@ export default Vue.extend({ ...@@ -154,6 +155,9 @@ export default Vue.extend({
if (this.currentBoard && Object.keys(this.currentBoard).length && this.currentPage !== 'new') { if (this.currentBoard && Object.keys(this.currentBoard).length && this.currentPage !== 'new') {
this.board = Vue.util.extend({}, this.currentBoard); this.board = Vue.util.extend({}, this.currentBoard);
} }
if (this.$refs.name) {
this.$refs.name.focus();
}
}, },
computed: { computed: {
buttonText() { buttonText() {
......
...@@ -11,17 +11,8 @@ ...@@ -11,17 +11,8 @@
Edit Edit
</a> </a>
</div> </div>
<div
v-if="editing"
class="dropdown open"
>
<input
v-if="fieldName"
:name="fieldName"
>
<slot></slot> <slot></slot>
</div> <div>
<div :class="{ invisible: editing }">
<slot name="currentValue"> <slot name="currentValue">
{{ defaultText }} {{ defaultText }}
</slot> </slot>
...@@ -30,7 +21,9 @@ ...@@ -30,7 +21,9 @@
</template> </template>
<script> <script>
export default { import eventHub from '../eventhub';
export default {
props: { props: {
defaultText: { defaultText: {
type: String, type: String,
...@@ -57,8 +50,8 @@ ...@@ -57,8 +50,8 @@
}, },
methods: { methods: {
toggleEditing() { toggleEditing() {
this.editing = !this.editing; eventHub.$emit('toggle');
}, },
}, },
}; };
</script> </script>
\ No newline at end of file
<template> <template>
<div class="dropdown-menu dropdown-menu-wide"> <div class="dropdown" :class="{ open: isOpen }">
<div
class="dropdown-menu dropdown-menu-wide"
>
<div class="dropdown-input"> <div class="dropdown-input">
<input <input
ref="search"
class="dropdown-input-field" class="dropdown-input-field"
type="search" type="search"
placeholder="Search milestones"> placeholder="Search milestones">
...@@ -19,7 +23,7 @@ ...@@ -19,7 +23,7 @@
@click.prevent.stop="selectMilestone(milestone)"> @click.prevent.stop="selectMilestone(milestone)">
<i <i
class="fa fa-check" class="fa fa-check"
v-if="false"></i> v-if="milestone.id === value"></i>
{{ milestone.title }} {{ milestone.title }}
</a> </a>
</li> </li>
...@@ -37,12 +41,13 @@ ...@@ -37,12 +41,13 @@
@click.prevent.stop="selectMilestone(milestone)"> @click.prevent.stop="selectMilestone(milestone)">
<i <i
class="fa fa-check" class="fa fa-check"
v-if="false"></i> v-if="milestone.id === value"></i>
{{ milestone.title }} {{ milestone.title }}
</a> </a>
</li> </li>
</ul> </ul>
</div> </div>
</div>
</template> </template>
<script> <script>
...@@ -50,6 +55,7 @@ ...@@ -50,6 +55,7 @@
import loadingIcon from '~/vue_shared/components/loading_icon.vue'; import loadingIcon from '~/vue_shared/components/loading_icon.vue';
import extraMilestones from '../mixins/extra_milestones'; import extraMilestones from '../mixins/extra_milestones';
import eventHub from '../eventhub';
export default { export default {
props: { props: {
...@@ -62,7 +68,7 @@ export default { ...@@ -62,7 +68,7 @@ export default {
required: true, required: true,
}, },
value: { value: {
type: String, type: Number,
required: false, required: false,
}, },
}, },
...@@ -71,6 +77,7 @@ export default { ...@@ -71,6 +77,7 @@ export default {
}, },
data() { data() {
return { return {
isOpen: false,
loading: true, loading: true,
milestones: [], milestones: [],
extraMilestones, extraMilestones,
...@@ -78,11 +85,32 @@ export default { ...@@ -78,11 +85,32 @@ export default {
}, },
mounted() { mounted() {
BoardService.loadMilestones.call(this).then(() => this.loading = false); BoardService.loadMilestones.call(this).then(() => this.loading = false);
eventHub.$on('open', this.open);
eventHub.$on('close', this.close);
eventHub.$on('toggle', this.toggle);
this.$nextTick(() => {
this.$refs.search.focus();
});
},
beforeDestroy() {
eventHub.$off('open', this.open);
eventHub.$off('close', this.close);
eventHub.$off('toggle', this.toggle);
}, },
methods: { methods: {
selectMilestone(milestone) { selectMilestone(milestone) {
this.board.milestone_id = milestone.id; this.board.milestone = milestone;
this.$emit('input', milestone); this.$emit('input', milestone.id);
this.close();
},
open() {
this.isOpen = true;
},
close() {
this.isOpen = false;
},
toggle() {
this.isOpen = !this.isOpen;
}, },
}, },
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment